Login  Register

[GitHub] carbondata pull request #1818: [CARBONDATA-2020][Old Store Support] Add filt...

classic Classic list List threaded Threaded
7 messages Options Options
Embed post
Permalink
Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] carbondata pull request #1818: [CARBONDATA-2020][Old Store Support] Add filt...

qiuchenjian-2
GitHub user manishgupta88 opened a pull request:

    https://github.com/apache/carbondata/pull/1818

    [CARBONDATA-2020][Old Store Support] Add filter support for old store reading to improve query performance

    **Problem**
    For old stores blocklet level min/max comparison was not happening in the executor side due to which all the blocklets were getting scanned. This increased the IO and scanning time in the executor.
   
    **Solution**
    Modified code to retrieve the min/max value from blocklet node and use it for comparsion while scanning for valid blocklets.
   
    **Note:** This PR need to be merged after #1796
   
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    No
     - [ ] Testing done
    Yes. Manually verified      
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manishgupta88/carbondata filter_support_for_old_store

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1818.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1818
   
----
commit b0c7f1211c74f478fe5f561872b655a1869d6756
Author: manishgupta88 <tomanishgupta18@...>
Date:   2018-01-17T05:57:09Z

    Add filter support for old store reading

----


---
Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] carbondata issue #1818: [CARBONDATA-2020][Old Store Support] Add filter supp...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1818
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2874/



---
Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] carbondata issue #1818: [CARBONDATA-2020][Old Store Support] Add filter supp...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1818
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1642/



---
Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] carbondata issue #1818: [CARBONDATA-2020][Old Store Support] Add filter supp...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1818
 
    retest sdv please


---
Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] carbondata issue #1818: [CARBONDATA-2020][Old Store Support] Add filter supp...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1818
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2980/



---
Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] carbondata issue #1818: [CARBONDATA-2020][Old Store Support] Add filter supp...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1818
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] carbondata pull request #1818: [CARBONDATA-2020][Old Store Support] Add filt...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1818


---