[GitHub] carbondata pull request #1824: [CARBONDATA-2046]agg Query failed when non su...

[qiuchenjian-2]

GitHub user BJangir opened a pull request:

    https://github.com/apache/carbondata/pull/1824

    [CARBONDATA-2046]agg Query failed when non supported aggregate is present in Query

    Root Cause :- isValidPlan variable was getting overwritten by CarbonReflectionUtils.hasPredicateSubquery(expression) .
   
    Solution :- CarbonReflectionUtils.hasPredicateSubquery(expression) method should be called when isValidPlan  is true to avoid overwritten.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed? NO
     
     - [ ] Any backward compatibility impacted? NO
     
     - [ ] Document update required?
    NO
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
         Added UI
       - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.  
     NA
            - Any additional information to help reviewers in testing this change.
          NA
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BJangir/incubator-carbondata CARBONDATA-2046

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1824.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1824
   
----
commit 4be2764f415cb50cb8785497500c069c69e9caa2
Author: BJangir <babulaljangir111@...>
Date:   2018-01-17T17:02:10Z

    agg Query failed when non supported aggregate is present in Query

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1824
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1675/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1824#discussion_r162137213
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala ---
    @@ -347,9 +347,9 @@ case class CarbonPreAggregateQueryRules(sparkSession: SparkSession) extends Rule
             }
           // case of handling aggregation query with filter
           case agg@Aggregate(
    -        grExp,
    -        aggExp,
    -        Filter(expression, child@CarbonSubqueryAlias(_, l: LogicalRelation)))
    +      grExp,
    --- End diff --
   
    Please add 2 space for all


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1824
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2908/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1824
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2951/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1824
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2974/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1824
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1718/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/1824
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1824


---