[GitHub] carbondata pull request #1836: [CARBONDATA-2058] Block append data to stream...

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1836: [CARBONDATA-2058] Block append data to stream...

qiuchenjian-2
GitHub user QiangCai opened a pull request:

    https://github.com/apache/carbondata/pull/1836

    [CARBONDATA-2058] Block append data to streaming segment after writing exception

    If  CarbonStreamRecordWriter happened an exception, mark hasException attribute to avoid appending data to the segment.
   
     - [x] Any interfaces changed?
     no
     - [x] Any backward compatibility impacted?
     no
     - [x] Document update required?
     no
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
             bugfix
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    small changes


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/QiangCai/carbondata streaming_NPE

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1836.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1836
   
----
commit f347ea8fc27ec82b0dbe9006bf0c0ceaf6629475
Author: QiangCai <qiangcai@...>
Date:   2018-01-19T09:28:57Z

    block append data to streaming segment after writing exception

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1836: [CARBONDATA-2058] Block append data to streaming seg...

qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1836
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2995/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1836: [CARBONDATA-2058] Block append data to streaming seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1836
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1752/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1836: [CARBONDATA-2058] Block append data to streaming seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1836
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2982/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1836: [CARBONDATA-2058] Block append data to streaming seg...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1836
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1836: [CARBONDATA-2058] Block append data to stream...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1836


---