[GitHub] carbondata pull request #1837: [WIP] Refactored code segregated process meta...

[qiuchenjian-2]

GitHub user kumarvishal09 opened a pull request:

    https://github.com/apache/carbondata/pull/1837

    [WIP] Refactored code segregated process meta and process data in load command

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kumarvishal09/incubator-carbondata CodeRefactor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1837.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1837
   
----
commit f8e6fc8b036a5fde537d2db135d8860fd2c50c95
Author: kumarvishal <kumarvishal.1802@...>
Date:   2018-01-19T11:52:28Z

    Refactor code segregated load from metadata

----


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1837#discussion_r162626990
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java ---
    @@ -136,7 +136,8 @@ public BlockletDataMap get(TableBlockIndexUniqueIdentifier identifier)
                 partitionFileStore.readAllPartitionsOfSegment(carbonFiles, segmentPath);
                 partitionFileStoreMap.put(identifier.getSegmentId(), partitionFileStore);
                 for (CarbonFile file : carbonFiles) {
    -              locationMap.put(file.getAbsolutePath(), file.getLocations());
    +              locationMap
    +                  .put(FileFactory.getUpdatedFilePath(file.getAbsolutePath()), file.getLocations());
    --- End diff --
   
    move .put to previous line


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1837#discussion_r162627861
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertIntoCommand.scala ---
    @@ -45,10 +47,10 @@ case class CarbonInsertIntoCommand(
           updateModel = None,
           tableInfoOp = None,
           internalOptions = Map.empty,
    -      partition = partition).run(sparkSession)
    -    // updating relation metadata. This is in case of auto detect high cardinality
    -    relation.carbonRelation.metaData =
    -      CarbonSparkUtil.createSparkMeta(relation.carbonRelation.carbonTable)
    -    load
    +      partition = partition)
    +    loadCommand.processMetadata(sparkSession)
    +  }
    +  override def processData(sparkSession: SparkSession): Seq[Row] = {
    +    loadCommand.processData(sparkSession)
    --- End diff --
   
    add `if (loadCommand != null)` check


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1764/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2994/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3001/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1771/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3007/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1777/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3012/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3008/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1778/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3013/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1781/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3011/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3014/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3015/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3012/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1782/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1837
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3016/



---