[GitHub] carbondata pull request #1841: [CARBONDATA-2062] Configure the temp director...

[qiuchenjian-2]

GitHub user sraghunandan opened a pull request:

    https://github.com/apache/carbondata/pull/1841

    [CARBONDATA-2062] Configure the temp directory to be used for streaming handoff

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
         No
     - [ ] Any backward compatibility impacted?
        No
     - [ ] Document update required?
      No
     - [ ] Testing done
       Yes
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
                No test cases added as only temp directory location is being changed
            - How it is tested? Please attach test report.
                 Tested to check the temp files location
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sraghunandan/carbondata-1 streaming_temp_dir

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1841.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1841
   
----
commit f115c543b10ed5f60c7954eb8f41cc20b57d9922
Author: Raghunandan S <carbondatacontributions@...>
Date:   2018-01-22T06:17:28Z

    configure the temp directory to be used for streaming handoff

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1841
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3027/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1841
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1796/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1841
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3027/



---

[qiuchenjian-2]

Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/1841
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1841
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1802/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1841
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3033/



---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1841#discussion_r162932133
 
    --- Diff: streaming/src/main/scala/org/apache/carbondata/streaming/StreamHandoffRDD.scala ---
    @@ -99,6 +101,38 @@ class StreamHandoffRDD[K, V](
         formatter.format(new Date())
       }
     
    +  private def setTempDirLocation(split: Partition) : Unit = {
    --- End diff --
   
    Better to reuse this code for CarbonMergerRDD , SparkPartitionLoader , AlterTableLoadPartitionRDD,  DataLoadProcessorStepOnSpark and CarbonFileFormat


---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1841#discussion_r163139005
 
    --- Diff: streaming/src/main/scala/org/apache/carbondata/streaming/StreamHandoffRDD.scala ---
    @@ -99,6 +101,38 @@ class StreamHandoffRDD[K, V](
         formatter.format(new Date())
       }
     
    +  private def setTempDirLocation(split: Partition) : Unit = {
    --- End diff --
   
    SparkPartitionLoader, DataLoadProcessorStepOnSpark, CarbonFileFormat uses array of locations to speed up the loading, can't use the same function to achieve the functionality


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1841
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3035/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1841
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1812/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1841
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3043/



---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1841#discussion_r163154276
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
    @@ -941,4 +943,39 @@ object CommonUtil {
         }
       }
     
    +  def setTempStoreLocation(
    +      index: Int,
    +      carbonLoadModel: CarbonLoadModel,
    +      isCompactionFlow: Boolean,
    +      isAltPartitionFlow: Boolean) : Unit = {
    +    var storeLocation: String = null
    +
    +    // this property is used to determine whether temp location for carbon is inside
    +    // container temp dir or is yarn application directory.
    +    val carbonUseLocalDir = CarbonProperties.getInstance()
    +      .getProperty("carbon.use.local.dir", "false")
    +
    +    if (carbonUseLocalDir.equalsIgnoreCase("true")) {
    +
    +      val storeLocations = Util.getConfiguredLocalDirs(SparkEnv.get.conf)
    +      if (null != storeLocations && storeLocations.nonEmpty) {
    +        storeLocation = storeLocations(Random.nextInt(storeLocations.length))
    +      }
    +      if (storeLocation == null) {
    +        storeLocation = System.getProperty("java.io.tmpdir")
    +      }
    +    } else {
    +      storeLocation = System.getProperty("java.io.tmpdir")
    +    }
    +    storeLocation = storeLocation + '/' + "carbon" + System.nanoTime() + '_' + index
    --- End diff --
   
    Please use CarbonCommonConstants.FILE_SEPARATOR & CarbonCommonConstants.UNDERSCORE instead of hard coded litral.
     


---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1841#discussion_r163167471
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
    @@ -941,4 +943,39 @@ object CommonUtil {
         }
       }
     
    +  def setTempStoreLocation(
    +      index: Int,
    +      carbonLoadModel: CarbonLoadModel,
    +      isCompactionFlow: Boolean,
    +      isAltPartitionFlow: Boolean) : Unit = {
    +    var storeLocation: String = null
    +
    +    // this property is used to determine whether temp location for carbon is inside
    +    // container temp dir or is yarn application directory.
    +    val carbonUseLocalDir = CarbonProperties.getInstance()
    +      .getProperty("carbon.use.local.dir", "false")
    +
    +    if (carbonUseLocalDir.equalsIgnoreCase("true")) {
    +
    +      val storeLocations = Util.getConfiguredLocalDirs(SparkEnv.get.conf)
    +      if (null != storeLocations && storeLocations.nonEmpty) {
    +        storeLocation = storeLocations(Random.nextInt(storeLocations.length))
    +      }
    +      if (storeLocation == null) {
    +        storeLocation = System.getProperty("java.io.tmpdir")
    +      }
    +    } else {
    +      storeLocation = System.getProperty("java.io.tmpdir")
    +    }
    +    storeLocation = storeLocation + '/' + "carbon" + System.nanoTime() + '_' + index
    --- End diff --
   
    handled


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1841
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3040/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1841
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1818/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1841
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3049/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1841
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1841
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3082/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1841
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1851/



---