[GitHub] carbondata pull request #1849: [HOTFIX] process VM error for the streaming w...

[qiuchenjian-2]

GitHub user QiangCai opened a pull request:

    https://github.com/apache/carbondata/pull/1849

    [HOTFIX] process VM error for the streaming writer

    process VM error for the streaming writer by using Throwable instead of Exception
   
     - [x] Any interfaces changed?
     
     - [x] Any backward compatibility impacted?
     
     - [x] Document update required?
   
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/QiangCai/carbondata catch_jvm_error

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1849.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1849
   
----
commit f09703a5cc91c6a3e9327dd5f5f7cf0a28611c6a
Author: QiangCai <qiangcai@...>
Date:   2018-01-23T13:12:32Z

    process vw error for streaming writer

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1849
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3060/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1849
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1828/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1849
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3051/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1849#discussion_r163767057
 
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/streaming/CarbonStreamRecordWriter.java ---
    @@ -173,6 +172,8 @@ private void initializeAtFirstRow() throws IOException, InterruptedException {
           outputStream = FileFactory.getDataOutputStream(filePath, fileType);
           writeFileHeader();
         }
    +
    +    isFirstRow = false;
    --- End diff --
   
    Please modify this in another PR


---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1849#discussion_r163767519
 
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/streaming/CarbonStreamRecordWriter.java ---
    @@ -173,6 +172,8 @@ private void initializeAtFirstRow() throws IOException, InterruptedException {
           outputStream = FileFactory.getDataOutputStream(filePath, fileType);
           writeFileHeader();
         }
    +
    +    isFirstRow = false;
    --- End diff --
   
    it means whether current row is first row or not


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1849
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1849


---