[GitHub] carbondata pull request #1861: [CARBONDATA-2078][CARBONDATA-1516] Add 'if no...

[qiuchenjian-2]

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/1861

    [CARBONDATA-2078][CARBONDATA-1516] Add 'if not exists' for creating datamap

   
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA2078_CreateDatamapIFNotExists

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1861.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1861
   
----
commit 16311b474ee1f9b9dbb30a9df8ce8026a99ee544
Author: xubo245 <601450868@...>
Date:   2018-01-25T13:27:27Z

    [CARBONDATA-2078][CARBONDATA-1516] Add 'if not exists' for creating datamap

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3130/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1897/



---

[qiuchenjian-2]

Github user BJangir commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    @xubo245 ,
     if agg table is already created and create datamap command is fired again with "if not exists" syntax then processMetadata will not return any Error (as expected ) but  then processData will be triggered
     and processData will throw error because createPreAggregateTableCommands is not initialized . So "table exists"  check need to handle in processData also .  Steps to reproduce
    1. Create table maintable
    2. load data maintable
    3. Create datamap map1 on table maintable
    4. Create datamap if not  exists map1 on table maintable



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3107/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    createPreAggregateTableCommands will be none  in processData when we create datamap with "if not exists" syntax .
   
    so When will throw error? can you give a example for " processData will throw error because createPreAggregateTableCommands is not initialized"?


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    @BJangir Can you give me the code of throw error?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3141/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1908/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3115/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    @xubo245 Please use the step provided by @BJangir and try to reproduce the issue.  


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    @kumarvishal09 @BJangir I tried before, but not happen according the step, please see: https://github.com/apache/carbondata/pull/1861/commits/723757f3343baa7d47d532ccdda268597023b769


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3196/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1962/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3159/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    @chenliang613 @jackylk @BJangir @kumarvishal09 @sraghunandan Please review it.


---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    @xubo245 Please rebase


---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    @xubo245 After merging #1865 we need to update the createdatamap class as now user will able only one timeseries table in one create data map command please change the code accordingly


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2039/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1861
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3278/



---