[GitHub] carbondata pull request #1881: [CARBONDATA-2095]Copy data of GenericInternal...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1881: [CARBONDATA-2095]Copy data of GenericInternal...

qiuchenjian-2
GitHub user zzcclp opened a pull request:

    https://github.com/apache/carbondata/pull/1881

    [CARBONDATA-2095]Copy data of GenericInternalRow for each iteration when converting stream segment to batch segment.

    ## Problem:
    After handoff stream segment(ROW format) to batch segment (column format), data is incorrect, there are repetitive data.
   
    ## Solution:
    Copy data of GenericInternalRow for each iteration when converting stream segment to batch segment.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zzcclp/carbondata CARBONDATA-2095

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1881.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1881
   
----
commit f205083c9f2c754305017fcb2baeef73dd2defed
Author: Zhang Zhichao <441586683@...>
Date:   2018-01-30T08:52:46Z

    [CARBONDATA-2095]Copy data of GenericInternalRow for each iteration when converting stream segment to batch segment.
   
    Problem:
    After handoff stream segment(ROW format) to batch segment (column format), data is incorrect, there are repetitive data.
   
    Solution:
    Copy data of GenericInternalRow for each iteration when converting stream segment to batch segment.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1881: [CARBONDATA-2095]Copy data of GenericInternalRow for...

qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1881
 
    @QiangCai  @jackylk  @chenliang613 please review, thanks.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1881: [CARBONDATA-2095]Copy data of GenericInternalRow for...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1881
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3256/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1881: [CARBONDATA-2095]Copy data of GenericInternalRow for...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1881
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1881: [CARBONDATA-2095]Copy data of GenericInternalRow for...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1881
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2022/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1881: [CARBONDATA-2095]Copy data of GenericInternal...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1881


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1881: [CARBONDATA-2095]Copy data of GenericInternalRow for...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1881
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3212/



---