[GitHub] carbondata pull request #1907: Data types

[qiuchenjian-2]

GitHub user sgururajshetty opened a pull request:

    https://github.com/apache/carbondata/pull/1907

    Data types

    Spelling fixed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sgururajshetty/carbondata data_types

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1907.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1907
   
----
commit e9fa0a2a09b89bbef10ea7a635ea929c54a58edc
Author: sgururajshetty <sgururajshetty@...>
Date:   2018-02-01T15:00:12Z

    The supported datatype mentioned for dictionary exclude and sort columns

commit 0a0af9d38359414cc194f8a9e2f6c5850c88e9f9
Author: sgururajshetty <sgururajshetty@...>
Date:   2018-02-01T15:03:34Z

    Spelling correction

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1907
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1907
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1907#discussion_r165394741
 
    --- Diff: docs/data-management-on-carbondata.md ---
    @@ -44,13 +44,16 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
       
        - **Dictionary Encoding Configuration**
     
    -     Dictionary encoding is turned off for all columns by default from 1.3 onwards, you can use this command for including columns to do dictionary encoding.
    +     Dictionary encoding is turned off for all columns by default from 1.3 onwards, you can use this command for including or excluding columns to do dictionary encoding.
          Suggested use cases : do dictionary encoding for low cardinality columns, it might help to improve data compression ratio and performance.
     
          ```
          TBLPROPERTIES ('DICTIONARY_INCLUDE'='column1, column2')
    + TBLPROPERTIES ('DICTIONARY_EXCLUDE'='column1, column2')
    --- End diff --
   
    By default, all columns are DICTIONARY_EXCLUDE, no need to specify.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1907
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1907
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1907


---