[GitHub] carbondata pull request #1910: [CARBONDATA-2112] Fixed bug for select operat...

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1910: [CARBONDATA-2112] Fixed bug for select operat...

qiuchenjian-2
GitHub user geetikagupta16 opened a pull request:

    https://github.com/apache/carbondata/pull/1910

    [CARBONDATA-2112] Fixed bug for select operation on datamap with avg and a column name

    1. Refactored code to get child column by parent column name for select operation in datamap
    2. Added related test case
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/geetikagupta16/incubator-carbondata CARBONDATA-2112

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1910.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1910
   
----
commit f7913d07584c52403711f512e4c870b2790eda7a
Author: Geetika Gupta <geetika.gupta@...>
Date:   2018-02-02T08:32:38Z

    1. Refactored code to get child column by parent column name for select operation in datamap
    2. Added related test case

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1910: [CARBONDATA-2112] Fixed bug for select operation on ...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1910
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3434/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1910: [CARBONDATA-2112] Fixed bug for select operation on ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1910
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2194/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1910: [CARBONDATA-2112] Fixed bug for select operation on ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1910
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3439/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1910: [CARBONDATA-2112] Fixed bug for select operation on ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1910
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2199/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1910: [CARBONDATA-2112] Fixed bug for select operation on ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1910
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3302/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1910: [CARBONDATA-2112] Fixed bug for select operation on ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1910
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3304/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1910: [CARBONDATA-2112] Fixed bug for select operation on ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/1910
 
    @geetikagupta16 can you write the existing problem with the code and the fix that you have done in the description.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1910: [CARBONDATA-2112] Fixed bug for select operation on ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/1910
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1910: [CARBONDATA-2112] Fixed bug for select operat...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1910


---