[GitHub] carbondata pull request #1911: [CARBONDATA-2119] Fixed deserialization issue...

[qiuchenjian-2]

GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/1911

    [CARBONDATA-2119] Fixed deserialization issues for carbonLoadModel

    **Problem:**
    Load model was not getting de-serialized in the executor due to which 2 different carbon table objects were being created.
    **Solution:**
    Reconstruct carbonTable from tableInfo if not already created.
   
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [X] Any interfaces changed?
     
     - [X] Any backward compatibility impacted?
     
     - [X] Document update required?
   
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata serialization_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1911.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1911
   
----
commit b69620be62b13a21a41d6c4e30430af288b2b82b
Author: kunal642 <kunalkapoor642@...>
Date:   2018-02-02T12:07:51Z

    fixed deserialization issues for carbonLoadModel

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1911
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2202/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1911
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3442/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1911
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3312/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1911
 
    @kunal642 Please fix the build errors


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1911#discussion_r165804520
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonDataLoadSchema.java ---
    @@ -51,7 +61,22 @@ public CarbonDataLoadSchema(CarbonTable carbonTable) {
        * @return carbonTable
        */
       public CarbonTable getCarbonTable() {
    +    readCarbonTable();
         return carbonTable;
       }
     
    -}
    +  private void readCarbonTable() {
    +    if (carbonTable == null) {
    +      try {
    +        carbonTable = CarbonTable.buildFromTableInfo(TableInfo.deserialize(tableInfoBytes));
    +      } catch (IOException io) {
    +        throw new RuntimeException(io);
    +      }
    +    }
    +  }
    +
    +  private Object readResolve() {
    +    return DataTypes.LONG;
    --- End diff --
   
    why it returns LONG? Please correct it


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1911
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3476/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1911
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2236/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1911
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2239/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1911
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3477/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1911
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3341/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1911
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2252/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1911
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3495/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1911
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3347/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1911
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2263/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1911
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3501/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1911
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3350/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1911
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1911


---