[GitHub] carbondata pull request #1932: [CARBONDATA-2131] Alter table adding long dat...

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1932: [CARBONDATA-2131] Alter table adding long dat...

qiuchenjian-2
GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/1932

    [CARBONDATA-2131] Alter table adding long datatype is failing but Create table with long type is successful, in Spark 2.1

    "Create table" supported data types and "alter add columns" supported data types should be consistent.
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [x] Testing done
            UT Added
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/incubator-carbondata alter_long

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1932.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1932
   
----
commit aa44536bf52435390f8958c928f0a9a6ce3352aa
Author: dhatchayani <dhatcha.official@...>
Date:   2018-02-05T10:51:09Z

    [CARBONDATA-2131] Alter table adding long datatype is failing but Create table with long type is successful, in Spark 2.1[

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1932: [CARBONDATA-2131] Alter table adding long datatype i...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1932
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2280/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1932: [CARBONDATA-2131] Alter table adding long datatype i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1932
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3517/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1932: [CARBONDATA-2131] Alter table adding long datatype i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/1932
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1932: [CARBONDATA-2131] Alter table adding long datatype i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1932
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3364/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1932: [CARBONDATA-2131] Alter table adding long datatype i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1932
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3518/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1932: [CARBONDATA-2131] Alter table adding long datatype i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1932
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2281/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1932: [CARBONDATA-2131] Alter table adding long datatype i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1932
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2283/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1932: [CARBONDATA-2131] Alter table adding long datatype i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1932
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3520/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1932: [CARBONDATA-2131] Alter table adding long datatype i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1932
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3366/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1932: [CARBONDATA-2131] Alter table adding long dat...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1932#discussion_r165971754
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableValidationTestCase.scala ---
    @@ -128,6 +128,24 @@ class AlterTableValidationTestCase extends Spark2QueryTest with BeforeAndAfterAl
           Row(new BigDecimal("123.45").setScale(2, RoundingMode.HALF_UP)))
       }
     
    +  test("test add long column before load") {
    +    sql("drop table if exists alterLong")
    +    sql("create table alterLong (name string) stored by 'carbondata'")
    +    sql("alter table alterLong add columns(newCol long)")
    +    sql("insert into alterLong select 'a',60000")
    +    checkAnswer(sql("select * from alterLong"), Row("a", 60000))
    +    sql("drop table if exists alterLong")
    +  }
    +
    +  test("test add long column after load") {
    +    sql("drop table if exists alterLong1")
    +    sql("create table alterLong1 (name string) stored by 'carbondata'")
    +    sql("insert into alterLong1 select 'a'")
    +    sql("alter table alterLong1 add columns(newCol long)")
    --- End diff --
   
    do one more load after alter


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1932: [CARBONDATA-2131] Alter table adding long datatype i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1932
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1932: [CARBONDATA-2131] Alter table adding long dat...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1932


---