[GitHub] carbondata pull request #1938: [CARBONDATA-2138] Added documentation for HEA...

[qiuchenjian-2]

GitHub user sgururajshetty opened a pull request:

    https://github.com/apache/carbondata/pull/1938

    [CARBONDATA-2138] Added documentation for HEADER option while loading data

    Added documentation for HEADER option in load data

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sgururajshetty/carbondata 2138

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1938.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1938
   
----
commit 20ec4b85d4bf41d1ee99402a8e59aa4ad5d1f08f
Author: sgururajshetty <sgururajshetty@...>
Date:   2018-02-06T15:28:59Z

    Added documentation for HEADER option while loading data

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1938
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1938
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1938
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1938#discussion_r166505141
 
    --- Diff: docs/data-management-on-carbondata.md ---
    @@ -407,6 +415,7 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
        projectjoindate,projectenddate,attendance,utilization,salary',
        'MULTILINE'='true','ESCAPECHAR'='\','COMPLEX_DELIMITER_LEVEL_1'='$',
        'COMPLEX_DELIMITER_LEVEL_2'=':',
    +   'HEADER'='false',
    --- End diff --
   
    suggest moving this line to 413 line.


---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1938#discussion_r166509548
 
    --- Diff: docs/data-management-on-carbondata.md ---
    @@ -330,6 +330,14 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
         OPTIONS('COMMENTCHAR'='#')
         ```
     
    +  - **HEADER:** When you load the CSV file without the file header and the file header is the same with the table schema, then add 'HEADER'='false' to load data SQL as user need not provide the file header. By default the value is 'true'.
    +  false: CSV file is without file header.
    +  true: CSV file is with file header.
    +  
    +    ```
    +    OPTIONS('HEADER'='false')
    +    ```
    +
       - **FILEHEADER:** Headers can be provided in the LOAD DATA command if headers are missing in the source files.
     
    --- End diff --
   
    suggest mentioning: If HEADER option exists and the value is true, not require FILEHEADER option.


---

[qiuchenjian-2]

Github user sgururajshetty commented on the issue:

    https://github.com/apache/carbondata/pull/1938
 
    @QiangCai fixed the review comment. Kindly review and merge.


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1938
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1938


---