[GitHub] carbondata pull request #1952: [HotFix][CheckStyle] Fix import related check...

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1952: [HotFix][CheckStyle] Fix import related check...

qiuchenjian-2
GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/1952

    [HotFix][CheckStyle] Fix import related checkstyle

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata hot_fix_checkstyle

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1952.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1952
   
----
commit 210437a9099b29d264f356714d23d942ecd9c20e
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-02-08T07:39:45Z

    Fix import related checkstyle

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1952: [HotFix][CheckStyle] Fix import related checkstyle

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1952
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3580/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1952: [HotFix][CheckStyle] Fix import related checkstyle

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1952
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2342/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1952: [HotFix][CheckStyle] Fix import related checkstyle

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1952
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3430/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1952: [HotFix][CheckStyle] Fix import related checkstyle

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/1952
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1952: [HotFix][CheckStyle] Fix import related checkstyle

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1952
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3592/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1952: [HotFix][CheckStyle] Fix import related checkstyle

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1952
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2354/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1952: [HotFix][CheckStyle] Fix import related checkstyle

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1952
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1952: [HotFix][CheckStyle] Fix import related checkstyle

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1952
 
    merged into carbonstore branch


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1952: [HotFix][CheckStyle] Fix import related check...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xuchuanyin closed the pull request at:

    https://github.com/apache/carbondata/pull/1952


---