[GitHub] carbondata pull request #1959: [CARBONDATA-2147][CARBONDATA-2148]Add new Row...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2396/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3472/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3474/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3643/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2404/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3652/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2413/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3489/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3492/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    retest sdv please


---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1959#discussion_r167416315
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/TestStreamingTableOperation.scala ---
    @@ -775,6 +776,8 @@ class TestStreamingTableOperation extends QueryTest with BeforeAndAfterAll {
                 .option("bad_records_action", badRecordAction)
                 .option("dbName", tableIdentifier.database.get)
                 .option("tableName", tableIdentifier.table)
    +            .option(CarbonStreamParser.CARBON_STREAM_PARSER,
    +              "org.apache.carbondata.streaming.parser.CSVStreamParserImp")
    --- End diff --
   
    Better to use default parser,
    Can you modify it, like CarbonStructuredStreamingExample.scala


---

[qiuchenjian-2]

Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1959#discussion_r167420058
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/TestStreamingTableOperation.scala ---
    @@ -775,6 +776,8 @@ class TestStreamingTableOperation extends QueryTest with BeforeAndAfterAll {
                 .option("bad_records_action", badRecordAction)
                 .option("dbName", tableIdentifier.database.get)
                 .option("tableName", tableIdentifier.table)
    +            .option(CarbonStreamParser.CARBON_STREAM_PARSER,
    +              "org.apache.carbondata.streaming.parser.CSVStreamParserImp")
    --- End diff --
   
    OK, I will modify it later.


---

[qiuchenjian-2]

Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1959#discussion_r167423204
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/TestStreamingTableOperation.scala ---
    @@ -775,6 +776,8 @@ class TestStreamingTableOperation extends QueryTest with BeforeAndAfterAll {
                 .option("bad_records_action", badRecordAction)
                 .option("dbName", tableIdentifier.database.get)
                 .option("tableName", tableIdentifier.table)
    +            .option(CarbonStreamParser.CARBON_STREAM_PARSER,
    +              "org.apache.carbondata.streaming.parser.CSVStreamParserImp")
    --- End diff --
   
    After PR#1962 is merged, I will modify it , otherwise there is error when write complex type data.


---

[qiuchenjian-2]

Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    @zzcclp pls update the PR template to fill up all the relevant points


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2636/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3881/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3660/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3892/



---