[GitHub] carbondata pull request #1959: [CARBONDATA-2147][CARBONDATA-2148]Add new Row...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2648/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3670/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3900/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2655/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3677/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3903/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2658/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    @QiangCai @jackylk please help to review, thanks.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3682/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2665/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3910/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3687/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1959#discussion_r170799400
 
    --- Diff: streaming/src/main/java/org/apache/carbondata/streaming/parser/CarbonStreamParser.java ---
    @@ -27,9 +28,10 @@
     
       String CARBON_STREAM_PARSER = "carbon.stream.parser";
     
    -  String CARBON_STREAM_PARSER_DEFAULT = "org.apache.carbondata.streaming.parser.CSVStreamParserImp";
    +  String CARBON_STREAM_PARSER_DEFAULT =
    +      "org.apache.carbondata.streaming.parser.RowStreamParserImp";
    --- End diff --
   
    I think it is better not to modify the default value of CARBON_STREAM_PARSER_DEFAULT, if user want to use org.apache.carbondata.streaming.parser.RowStreamParserImp, user can use it by setting `carbon.stream.parser` in the option when loading


---

[qiuchenjian-2]

Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1959#discussion_r170832185
 
    --- Diff: streaming/src/main/java/org/apache/carbondata/streaming/parser/CarbonStreamParser.java ---
    @@ -27,9 +28,10 @@
     
       String CARBON_STREAM_PARSER = "carbon.stream.parser";
     
    -  String CARBON_STREAM_PARSER_DEFAULT = "org.apache.carbondata.streaming.parser.CSVStreamParserImp";
    +  String CARBON_STREAM_PARSER_DEFAULT =
    +      "org.apache.carbondata.streaming.parser.RowStreamParserImp";
    --- End diff --
   
    OK


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2684/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3930/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2689/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3935/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3702/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1959
 
    LGTM


---