[GitHub] carbondata pull request #1974: [CARBONDATA-2166][Tests] Fix bugs in default ...

[qiuchenjian-2]

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/1974

    [CARBONDATA-2166][Tests] Fix bugs in default value of cutoff timestamp

    1. Add default value of cutoff timestamp based on document
    2. Fixed timezone for sdvtests
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     `NO`
     - [x] Any backward compatibility impacted?
    `NO`
     - [x] Document update required?
    `NO`
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0212_ts_cutoff

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1974.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1974
   
----
commit 74e599b1d1ff477757142cb7f7eb13968e465739
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-02-12T09:30:58Z

    Fix bugs in default value of cutoff timestamp
   
    1. Add default value of cutoff timestamp based on document
    2. Fixed timezone for sdvtests

----


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1974#discussion_r167502743
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/keygenerator/directdictionary/timestamp/TimeStampGranularityConstants.java ---
    @@ -27,6 +27,10 @@
        * customized the start of position. for example "January 1, 2000"
        */
       String CARBON_CUTOFF_TIMESTAMP = "carbon.cutOffTimestamp";
    +  /**
    +   * default value of cutoff timestamp
    +   */
    +  String CARBON_CUTOFF_TIMESTAMP_DEFAULT_VAL = "1970-01-01 05:30:00";
    --- End diff --
   
    FYI:
   
    This is set based on `configuration-parameters.md`.
   
    Dictionary value of timestamp will be generated as following:
    1. Convert the value to Date（d1）；
    2. Get the ms of the Date value （ts = d1.getTime()）；
    3. Calculate the key for ts. If ts < cutOffTimeStamp, then it be treated as bad record, otherwise carbondata will generate the key...


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1974
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3720/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1974
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2480/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/1974
 
    retest this please


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1974#discussion_r167529353
 
    --- Diff: integration/spark-common-cluster-test/src/test/scala/org/apache/spark/sql/common/util/QueryTest.scala ---
    @@ -34,13 +34,20 @@ import org.apache.spark.sql.{CarbonSession, DataFrame, Row, SQLContext}
     import org.scalatest.Suite
     
     import org.apache.carbondata.core.datastore.impl.FileFactory
    +import org.apache.carbondata.core.keygenerator.directdictionary.timestamp.TimeStampGranularityConstants
    +import org.apache.carbondata.core.util.CarbonProperties
     
     class QueryTest extends PlanTest with Suite {
     
       val LOGGER = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
     
       val DOLLAR = "$"
     
    +  // timezone is fix for timestamp related tests
    +  TimeZone.setDefault(TimeZone.getTimeZone("GMT"))
    +  CarbonProperties.getInstance().addProperty(
    +    TimeStampGranularityConstants.CARBON_CUTOFF_TIMESTAMP,
    +    TimeStampGranularityConstants.CARBON_CUTOFF_TIMESTAMP_DEFAULT_VAL)
       // Add Locale setting
    --- End diff --
   
    These settings will make sure that if the value of dictionary-encoded-timestamp column is less than `1970-01-01 05:30:00`, it will be treated as a bad record.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1974
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3522/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1974
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3524/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/1974
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1974
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2490/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1974
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3730/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/1974
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1974
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3735/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1974
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2495/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1974
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3534/



---

[qiuchenjian-2]

Github user xuchuanyin closed the pull request at:

    https://github.com/apache/carbondata/pull/1974


---