[GitHub] carbondata pull request #1975: [CARBONDATA-2142] [CARBONDATA-1763] Fixed iss...

[qiuchenjian-2]

GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/1975

    [CARBONDATA-2142] [CARBONDATA-1763] Fixed issues while creation concurrent datamaps

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [X] Any interfaces changed?
     
     - [X] Any backward compatibility impacted?
     
     - [X] Document update required?
   
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata concurrent_datamap_creation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1975.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1975
   
----
commit 37c0630f93e4d05c7e255fc5b13d277273f65077
Author: kunal642 <kunalkapoor642@...>
Date:   2018-02-12T19:23:31Z

    fixed issues while creation concurrent datamaps

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1975
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2488/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1975
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3728/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1975
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3529/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1975
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3729/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1975
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2489/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1975
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3530/



---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/1975
 
    @ravipesala please review


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1975#discussion_r170170644
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonDropDataMapCommand.scala ---
    @@ -65,8 +65,9 @@ case class CarbonDropDataMapCommand(
         catalog.checkSchemasModifiedTimeAndReloadTable(TableIdentifier(tableName, Some(dbName)))
         val carbonLocks: scala.collection.mutable.ListBuffer[ICarbonLock] = ListBuffer()
         try {
    +      forceDropTableFromMetaStore(sparkSession)
           locksToBeAcquired foreach {
    -        lock => carbonLocks += CarbonLockUtil.getLockObject(tableIdentifier, lock)
    +          lock => carbonLocks += CarbonLockUtil.getLockObject(tableIdentifier, lock)
    --- End diff --
   
    correct the format


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1975#discussion_r170171750
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala ---
    @@ -445,11 +443,11 @@ object PreAggregateUtil {
             .fromWrapperToExternalTableInfo(wrapperTableInfo, dbName, tableName)
           updateSchemaInfo(carbonTable,
             thriftTable)(sparkSession)
    -      LOGGER.info(s"Parent table updated is successful for table $dbName.$tableName")
    +      LOGGER.info(s"Parent table updated is successful for table" +
    +                  s" $dbName.${childSchema.getRelationIdentifier.toString}")
         } catch {
           case e: Exception =>
             LOGGER.error(e, "Pre Aggregate Parent table update failed reverting changes")
    -        revertMainTableChanges(dbName, tableName, numberOfCurrentChild)(sparkSession)
    --- End diff --
   
    Now where you are reverting the schema if updation fails?


---

[qiuchenjian-2]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1975#discussion_r170174790
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala ---
    @@ -445,11 +443,11 @@ object PreAggregateUtil {
             .fromWrapperToExternalTableInfo(wrapperTableInfo, dbName, tableName)
           updateSchemaInfo(carbonTable,
             thriftTable)(sparkSession)
    -      LOGGER.info(s"Parent table updated is successful for table $dbName.$tableName")
    +      LOGGER.info(s"Parent table updated is successful for table" +
    +                  s" $dbName.${childSchema.getRelationIdentifier.toString}")
         } catch {
           case e: Exception =>
             LOGGER.error(e, "Pre Aggregate Parent table update failed reverting changes")
    -        revertMainTableChanges(dbName, tableName, numberOfCurrentChild)(sparkSession)
    --- End diff --
   
    If updation of the parent table fails then the aggregate table will be dropped from undoMetadata. There is no need to revert the main table changes here.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1975
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3835/



---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/1975
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1975
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3837/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1975
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2592/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1975
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3622/



---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/1975
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1975
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3852/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1975
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2607/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1975
 
    LGTM


---