[GitHub] carbondata pull request #1993: [CARBONDATA-2199] Fixed Dimension column afte...

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1993: [CARBONDATA-2199] Fixed Dimension column afte...

qiuchenjian-2
GitHub user jatin9896 opened a pull request:

    https://github.com/apache/carbondata/pull/1993

    [CARBONDATA-2199] Fixed Dimension column after restructure getting wrong block datatype

    Problem: Changing datatype of measure having sort_columns calls for restructure and after having restructure it changes the datatype to actual datatype for which accessing the data with changed datatype gives exception of incorrect length.
   
    Solution: Store the datatype in DimensionInfo while restructuring and access the same datatype to get the block data type.
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed? No
     
     - [ ] Any backward compatibility impacted? No
     
     - [ ] Document update required? No
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required? Yes
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jatin9896/incubator-carbondata CARBONDATA-2199

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1993.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1993
   
----
commit 591c83f38be254ec0fa0e4a3d6423b244e9d106f
Author: Jatin <jatin.demla@...>
Date:   2018-02-23T11:26:17Z

    Fixed Dimension column after restructure getting wrong block datatype

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1993: [CARBONDATA-2199] Fixed Dimension column after restr...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1993
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3847/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1993: [CARBONDATA-2199] Fixed Dimension column after restr...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1993
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2602/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1993: [CARBONDATA-2199] Fixed Dimension column after restr...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1993
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2603/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1993: [CARBONDATA-2199] Fixed Dimension column after restr...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1993
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3848/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1993: [CARBONDATA-2199] Fixed Dimension column after restr...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1993
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3630/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1993: [CARBONDATA-2199] Fixed Dimension column after restr...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1993
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3631/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1993: [CARBONDATA-2199] Fixed Dimension column after restr...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1993
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2622/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1993: [CARBONDATA-2199] Fixed Dimension column after restr...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1993
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3867/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1993: [CARBONDATA-2199] Fixed Dimension column after restr...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1993
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3648/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1993: [CARBONDATA-2199] Fixed Dimension column after restr...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1993
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3950/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1993: [CARBONDATA-2199] Fixed Dimension column after restr...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1993
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2705/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1993: [CARBONDATA-2199] Fixed Dimension column after restr...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1993
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1993: [CARBONDATA-2199] Fixed Dimension column after restr...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1993
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3708/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1993: [CARBONDATA-2199] Fixed Dimension column afte...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1993


---