[GitHub] carbondata pull request #2008: [CARBONDATA-2211] in case of DDL HndOff shoul...

[qiuchenjian-2]

GitHub user rahulforallp opened a pull request:

    https://github.com/apache/carbondata/pull/2008

    [CARBONDATA-2211] in case of DDL HndOff should not be execute in thread

    If handoff triggered from DDL it should not execute in thread.
   
     - [ ] Any interfaces changed? No
     
     - [ ] Any backward compatibility impacted? No
     
     - [ ] Document update required? No
   
     - [ ] Testing done  Manual testing Done
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rahulforallp/incubator-carbondata CARBONDATA-2211

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2008.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2008
   
----
commit eb3a536e88b6550d9e004aa6eeddc992168c16b9
Author: rahulforallp <rahul.kumar@...>
Date:   2018-02-27T16:20:20Z

    [CARBONDATA-2211] in case of DDL HndOff should not be execute in thread

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2008
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2712/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2008
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3957/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2008
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3713/



---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2008#discussion_r171448904
 
    --- Diff: streaming/src/main/scala/org/apache/carbondata/streaming/StreamHandoffRDD.scala ---
    @@ -277,15 +277,21 @@ object StreamHandoffRDD {
        */
       def startStreamingHandoffThread(
           carbonLoadModel: CarbonLoadModel,
    -      sparkSession: SparkSession
    +      sparkSession: SparkSession,
    +      isDDL: Boolean
       ): Unit = {
         // start a new thread to execute streaming segment handoff
         val handoffThread = new Thread() {
    --- End diff --
   
    move this code to the inside of the if statement


---

[qiuchenjian-2]

Github user rahulforallp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2008#discussion_r171465697
 
    --- Diff: streaming/src/main/scala/org/apache/carbondata/streaming/StreamHandoffRDD.scala ---
    @@ -277,15 +277,21 @@ object StreamHandoffRDD {
        */
       def startStreamingHandoffThread(
           carbonLoadModel: CarbonLoadModel,
    -      sparkSession: SparkSession
    +      sparkSession: SparkSession,
    +      isDDL: Boolean
       ): Unit = {
         // start a new thread to execute streaming segment handoff
         val handoffThread = new Thread() {
    --- End diff --
   
    Done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2008
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4000/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2008
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2756/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2008
 
    please modify 'HndOff' to 'HandOff' in title.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2008
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4007/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2008
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2763/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2008
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4010/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2008
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2766/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/2008
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2008


---