[GitHub] carbondata pull request #2012: [CARBONDATA-2216][Test] Fix bugs in sdv tests

[qiuchenjian-2]

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2012

    [CARBONDATA-2216][Test] Fix bugs in sdv tests

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     `NO`
     - [x] Any backward compatibility impacted?
      `NO`
     - [x] Document update required?
     `NO`
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0228_dm_test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2012.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2012
   
----
commit 632032f965f53e999d4357fc4ef87fcf87e459f3
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-02-28T08:02:55Z

    Fix bugs in sdv tests

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2012
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3977/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2012
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2733/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2012
 
    LGTM


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2012
 
    merged into datamap branch


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2012
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3734/



---

[qiuchenjian-2]

Github user xuchuanyin closed the pull request at:

    https://github.com/apache/carbondata/pull/2012


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2012
 
    @ravipesala The sdvtest complains that
    ```
    Error Message
    2 did not equal 1
    Stacktrace
          org.scalatest.exceptions.TestFailedException: 2 did not equal 1
          at org.scalatest.Assertions$class.newAssertionFailedException(Assertions.scala:500)
          at org.scalatest.FunSuite.newAssertionFailedException(FunSuite.scala:1555)
          at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:466)
          at org.apache.carbondata.cluster.sdv.generated.MergeIndexTestCase$$anonfun$3.apply$mcV$sp(MergeIndexTestCase.scala:97)
    ```
    But actually I cloned the `sdv-test_data` branch in your repo and tested it in local, the dataloading only generated 1 *.index file not 2.
   
    Is there any different from the CI env and Local env?


---