[GitHub] carbondata pull request #2017: [CARBONDATA-2217]fix drop partition for non e...

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2017: [CARBONDATA-2217]fix drop partition for non e...

qiuchenjian-2
GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/2017

    [CARBONDATA-2217]fix drop partition for non existing partition and set FactTimeStamp during compaction for partition table

    **Problem:**
    1)when drop partition is fired for a column which does not exists , it throws null pointer exception
    2)select * is not working when clean files operation is fired after second level of compaction, it throws exception sometimes
   
    **Solution:**
    1)have a null check , if column does not exists
    2)give different timestamp for fact files during compaction to avoid deletion of files during clean files
    3) This PR also contains fix for creating a pre aggregate table with same name which has already created in other database
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     NA
     - [x] Any backward compatibility impacted?
     NA
     - [x] Document update required?
    NA
     - [x] Testing done
    Added UTs
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata partition_global

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2017.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2017
   
----
commit 3b66b06a3ed733ae938271361ff9f1af81fbf7a7
Author: akashrn5 <akashnilugal@...>
Date:   2018-02-28T11:58:43Z

    fix drop partition for non existing partition and set FactTimeStamp during compaction for partition table

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2017: [CARBONDATA-2217]fix drop partition for non existing...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2017
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4001/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2017: [CARBONDATA-2217]fix drop partition for non existing...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2017
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2757/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2017: [CARBONDATA-2217]fix drop partition for non existing...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2017
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4003/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2017: [CARBONDATA-2217]fix drop partition for non existing...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2017
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2759/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2017: [CARBONDATA-2217]fix drop partition for non existing...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2017
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2769/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2017: [CARBONDATA-2217]fix drop partition for non existing...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2017
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4013/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2017: [CARBONDATA-2217]fix drop partition for non existing...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2017
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2017: [CARBONDATA-2217]fix drop partition for non existing...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2017
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4032/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2017: [CARBONDATA-2217]fix drop partition for non existing...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2017
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2787/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2017: [CARBONDATA-2217]fix drop partition for non existing...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2017
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2790/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2017: [CARBONDATA-2217]fix drop partition for non existing...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2017
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4036/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2017: [CARBONDATA-2217]fix drop partition for non existing...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2017
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2017: [CARBONDATA-2217]fix drop partition for non e...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2017


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2017: [CARBONDATA-2217]fix drop partition for non existing...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2017
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3749/



---