[GitHub] carbondata pull request #2024: [HOTFIX] Fixed all examples

[qiuchenjian-2]

GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/2024

    [HOTFIX] Fixed all examples

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata example-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2024.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2024
   
----
commit a1312bf7275c4f4108ee73566b92410a0bb1e866
Author: ravipesala <ravi.pesala@...>
Date:   2018-03-02T16:16:50Z

    Fixed all examples

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2024
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2803/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2024
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4049/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2024
 
    retest this please


---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2024#discussion_r171992561
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonDataFrameExample.scala ---
    @@ -54,13 +54,13 @@ object CarbonDataFrameExample {
         // Saves dataframe to carbondata file
         df.write
           .format("carbondata")
    -      .option("tableName", "carbon_table")
    +      .option("tableName", "carbon_df_table")
    --- End diff --
   
    why requires to rename table name, is there any rule?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2024
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2805/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2024
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4051/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2024#discussion_r172003787
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonDataFrameExample.scala ---
    @@ -54,13 +54,13 @@ object CarbonDataFrameExample {
         // Saves dataframe to carbondata file
         df.write
           .format("carbondata")
    -      .option("tableName", "carbon_table")
    +      .option("tableName", "carbon_df_table")
    --- End diff --
   
    I have just changed because of creating fails sometimes because all other examples use the same name and also better differentiate the table name as per example.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2024
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4052/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2024
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2806/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2024
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2024


---