[GitHub] carbondata pull request #2059: [CARBONDATA-2250][DataLoad] Reduce massive ob...

[qiuchenjian-2]

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2059

    [CARBONDATA-2250][DataLoad] Reduce massive object generation in global sort

    Generate compatator outside the function, otherwise it will be generated
    for every row
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     `NO`
     - [x] Any backward compatibility impacted?
      `NO`
     - [x] Document update required?
     `NO`
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
     `NO`
            - How it is tested? Please attach test report.
    `Tested in local machine`
            - Is it a performance related change? Please attach the performance test report.
     `Performance should be slightly enhanced`
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0313_optimize_global_sort_comparator

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2059.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2059
   
----
commit b4d4d7a945949cec02064466e53f3b18d576fd58
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-03-13T07:49:48Z

    Reduce massive object generation in global sort
   
    generate compatator outside the function, otherwise it will be generated
    for every row

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2059
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4240/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2059
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2996/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2059
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3882/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2059#discussion_r174193598
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/NewRowComparatorForNormalDims.java ---
    @@ -16,13 +16,16 @@
      */
     package org.apache.carbondata.processing.sort.sortdata;
     
    +import java.io.Serializable;
     import java.util.Comparator;
     
     /**
      * This class is used as comparator for comparing dims which are non high cardinality dims.
      * Here the dims will be in form of int[] (surrogates) so directly comparing the integers.
      */
    -public class NewRowComparatorForNormalDims implements Comparator<Object[]> {
    +public class NewRowComparatorForNormalDims implements Comparator<Object[]>, Serializable {
    +  private static final long serialVersionUID = 201803131547L;
    --- End diff --
   
    please change the serialVersionUID


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2059
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3013/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2059
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4257/



---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2059#discussion_r174364855
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/NewRowComparatorForNormalDims.java ---
    @@ -16,13 +16,16 @@
      */
     package org.apache.carbondata.processing.sort.sortdata;
     
    +import java.io.Serializable;
     import java.util.Comparator;
     
     /**
      * This class is used as comparator for comparing dims which are non high cardinality dims.
      * Here the dims will be in form of int[] (surrogates) so directly comparing the integers.
      */
    -public class NewRowComparatorForNormalDims implements Comparator<Object[]> {
    +public class NewRowComparatorForNormalDims implements Comparator<Object[]>, Serializable {
    +  private static final long serialVersionUID = 201803131547L;
    --- End diff --
   
    fixed


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2059
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2059
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3111/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2059
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4345/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2059
 
    retest this please


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2059
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2059


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2059
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3142/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2059
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4364/



---