[GitHub] carbondata pull request #2089: [wip]revert logic of not deleting lock file, ...

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2089: [wip]revert logic of not deleting lock file, ...

qiuchenjian-2
GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/2089

    [wip]revert logic of not deleting lock file, and delete lock file during unlock only if it had acquired lock before

    revert logic of not deleting lock file, and delete lock file during unlock only if it had acquired lock before
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata hdfs_lock

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2089.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2089
   
----
commit 3378899feb928804e409343e4ff294a48d515405
Author: akashrn5 <akashnilugal@...>
Date:   2018-03-22T06:15:42Z

    revert logic of not deleting lock file, and delete lock file during unlock only if it had acquired lock before

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2089: [wip]revert logic of not deleting lock file, and del...

qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2089
 
    @akashrn5 why revert this logic? and why just revert this logic for HDFS?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2089: [wip]revert logic of not deleting lock file, and del...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2089
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4007/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2089: [wip]revert logic of not deleting lock file, and del...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2089
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4499/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2089: [wip]revert logic of not deleting lock file, and del...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2089
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3270/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2089: [wip]revert logic of not deleting lock file, and del...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/2089
 
    @zzcclp we are testing the concurrent scenarios with this change, im still in testing phase of this PR if it can solve the concurent issues of lock in hdfs


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2089: [wip]revert logic of not deleting lock file, ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user akashrn5 closed the pull request at:

    https://github.com/apache/carbondata/pull/2089


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2089: [wip]revert logic of not deleting lock file, and del...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2089
 
    ok, thanks for your reply, if it needs to revert this logic, we need to discuss whether remove the logic of deleting segment lock file auto.


---