[GitHub] carbondata pull request #2097: [CARBONDATA-2275]Query Failed for 0 byte dele...

[qiuchenjian-2]

GitHub user BJangir opened a pull request:

    https://github.com/apache/carbondata/pull/2097

    [CARBONDATA-2275]Query Failed for 0 byte deletedelta file

    When delete is failed on write step because of any exception from hdfs . Currently 0 bye deletedelta file is created and not getting cleaned up .
   
    So when any Select Query is triggered , Select Query is failed
   
    Root Cause:-
    1.  deletedelta of 0 size was considered for reader and while getting the hostname it has thrown IndexOutofBound
    2. Even Writer is failed while flush /close (exception from hdfs) but Exception is not thrown back to caller which is making delete operation is success.
   
    Solution :-
    1. While reading ignore 0 size deletedelta file
    2. When Writer is failed ,Throw Failure Exception to caller and show error on query client .
    3.  deletedelta of 0 byte will be handled in cleanup automatically in next delete/update .
   
   
     - [ ] Any interfaces changed?
     NA
     - [ ] Any backward compatibility impacted?
     NA
     - [ ] Document update required?
    NA
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           Testing is Done Manually.
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BJangir/incubator-carbondata CARBONDATA-2275

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2097.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2097
   
----
commit 491d602644c0d68cf7f9c4c88a10984a66ece5a5
Author: BJangir <babulaljangir111@...>
Date:   2018-03-23T18:08:22Z

    [CARBONDATA-2275]Query Failed for 0 byte deletedelta file

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2097
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3321/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2097
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4548/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2097
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4047/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2097
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2097
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3324/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2097
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4551/



---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2097#discussion_r176899943
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/writer/CarbonDeleteDeltaWriterImpl.java ---
    @@ -81,7 +80,9 @@ public CarbonDeleteDeltaWriterImpl(String filePath, FileFactory.FileType fileTyp
           if (null != dataOutStream) {
             dataOutStream.flush();
           }
    -      CarbonUtil.closeStreams(brWriter, dataOutStream);
    +      if (null != brWriter) {
    +        brWriter.close();
    +      }
    --- End diff --
   
    there is a catch block above in this method for IOException.....there we are only logging the exception...kindly add a throw statement in that catch block also after logging the error


---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2097#discussion_r176899945
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/writer/CarbonDeleteDeltaWriterImpl.java ---
    @@ -110,7 +111,9 @@ public CarbonDeleteDeltaWriterImpl(String filePath, FileFactory.FileType fileTyp
           if (null != dataOutStream) {
             dataOutStream.flush();
           }
    -      CarbonUtil.closeStreams(brWriter, dataOutStream);
    +      if (null != brWriter) {
    +        brWriter.close();
    +      }
    --- End diff --
   
    there is a catch block above in this method for IOException.....there we are only logging the exception...kindly add a throw statement in that catch block also after logging the error


---

[qiuchenjian-2]

Github user BJangir commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2097#discussion_r176946937
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/writer/CarbonDeleteDeltaWriterImpl.java ---
    @@ -110,7 +111,9 @@ public CarbonDeleteDeltaWriterImpl(String filePath, FileFactory.FileType fileTyp
           if (null != dataOutStream) {
             dataOutStream.flush();
           }
    -      CarbonUtil.closeStreams(brWriter, dataOutStream);
    +      if (null != brWriter) {
    +        brWriter.close();
    +      }
    --- End diff --
   
    Fixed


---

[qiuchenjian-2]

Github user BJangir commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2097#discussion_r176946943
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/writer/CarbonDeleteDeltaWriterImpl.java ---
    @@ -81,7 +80,9 @@ public CarbonDeleteDeltaWriterImpl(String filePath, FileFactory.FileType fileTyp
           if (null != dataOutStream) {
             dataOutStream.flush();
           }
    -      CarbonUtil.closeStreams(brWriter, dataOutStream);
    +      if (null != brWriter) {
    +        brWriter.close();
    +      }
    --- End diff --
   
    Fixed


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2097
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4078/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2097
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4581/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2097
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3355/



---

[qiuchenjian-2]

Github user BJangir commented on the issue:

    https://github.com/apache/carbondata/pull/2097
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2097
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3356/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2097
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4582/



---

[qiuchenjian-2]

Github user BJangir commented on the issue:

    https://github.com/apache/carbondata/pull/2097
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2097
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3369/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2097
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4595/



---