[GitHub] carbondata pull request #2111: [CARBONDATA-2292] Fix the problem of differen...

[qiuchenjian-2]

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/2111

    [CARBONDATA-2292] Fix the problem of different module dependencies different version spark jar

    When select spark2.2 in profile, then dependencies jars will spark2.1.0 and spark2.2.1,, which maybe lead to conflict. Carbon should Fix the problem and keep one version
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA-2292_multiSparkVersion

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2111
   
----
commit 9acb2d6f901cd2120eef2fd91302babea30cc960
Author: xubo245 <601450868@...>
Date:   2018-03-29T02:54:28Z

    [CARBONDATA-2292] Different module dependencies different version spark jar
   
    Fix the problem and keep one version

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2111
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3418/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2111
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4153/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2111
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4644/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2111
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2111
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4159/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2111
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2111
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4167/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2111#discussion_r178073421
 
    --- Diff: integration/presto/pom.xml ---
    @@ -436,13 +436,13 @@
           <groupId>org.apache.spark</groupId>
           <artifactId>spark-network-common_2.11</artifactId>
    --- End diff --
   
    use `${scala.binary.version}`


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2111#discussion_r178073457
 
    --- Diff: integration/presto/pom.xml ---
    @@ -436,13 +436,13 @@
           <groupId>org.apache.spark</groupId>
           <artifactId>spark-network-common_2.11</artifactId>
           <scope>test</scope>
    -      <version>2.1.0</version>
    +      <version>${spark.version}</version>
         </dependency>
         <dependency>
           <groupId>org.apache.spark</groupId>
           <artifactId>spark-core_2.11</artifactId>
    --- End diff --
   
    use `${scala.binary.version}`


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2111#discussion_r178218492
 
    --- Diff: integration/presto/pom.xml ---
    @@ -436,13 +436,13 @@
           <groupId>org.apache.spark</groupId>
           <artifactId>spark-network-common_2.11</artifactId>
    --- End diff --
   
    ok,done


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2111#discussion_r178218505
 
    --- Diff: integration/presto/pom.xml ---
    @@ -436,13 +436,13 @@
           <groupId>org.apache.spark</groupId>
           <artifactId>spark-network-common_2.11</artifactId>
           <scope>test</scope>
    -      <version>2.1.0</version>
    +      <version>${spark.version}</version>
         </dependency>
         <dependency>
           <groupId>org.apache.spark</groupId>
           <artifactId>spark-core_2.11</artifactId>
    --- End diff --
   
    ok,done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2111
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4675/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2111
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3448/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2111
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4185/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2111


---