[GitHub] carbondata pull request #2117: [CARBONDATA-2285] Spark integration code refa...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2117: [CARBONDATA-2285] Spark integration code refa...

qiuchenjian-2
GitHub user mohammadshahidkhan opened a pull request:

    https://github.com/apache/carbondata/pull/2117

    [CARBONDATA-2285] Spark integration code refactor

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [X] Any interfaces changed?
     NA
     - [X] Any backward compatibility impacted?
     NA
     - [X] Document update required?
    NA
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           No functional change only did the code refactor.
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata code_refactor_branch-1.3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2117
   
----
commit 2858b3ffc5e88bdfb96fcfb8cfaeac69a855bf8c
Author: mohammadshahidkhan <mohdshahidkhan1987@...>
Date:   2018-03-26T11:06:29Z

    [CARBONDATA-2285] Spark integration code refactor

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2117: [CARBONDATA-2285] Spark integration code refactor

qiuchenjian-2
Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2117
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2117: [CARBONDATA-2285] Spark integration code refactor

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2117
 
    Already merged to master as part of PR #2104


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2117: [CARBONDATA-2285] Spark integration code refa...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user mohammadshahidkhan closed the pull request at:

    https://github.com/apache/carbondata/pull/2117


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2117: [CARBONDATA-2285] Spark integration code refactor

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2117
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4693/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2117: [CARBONDATA-2285] Spark integration code refactor

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2117
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3466/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2117: [CARBONDATA-2285] Spark integration code refactor

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2117
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4201/



---