[GitHub] carbondata pull request #2122: [CARBONDATA-2296] Fix create datamap command ...

[qiuchenjian-2]

GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/2122

    [CARBONDATA-2296] Fix create datamap command with out on table syntax and correct the target location of test framework

    Problem
    1 Create datamap command fails if user does not mention `on table`
    2 Test framework try to create metastore and store location in integration/spark-common location but if it runs from other modules like datamap it creates target location in wrong place.
    Solution
    Check the null for parent table if not present and always take the present module target location as store path location if it not under integration module.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata testframeworkupdate

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2122
   
----
commit a6c19b83d21133788b2371ff37f03b86e0eb76dc
Author: ravipesala <ravi.pesala@...>
Date:   2018-03-31T02:42:44Z

    Fix create datamap command with out on table syntax and correct the target location of test framework

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2122
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4699/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2122
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3472/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2122
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4207/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2122#discussion_r178422490
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/IndexDataMapProvider.java ---
    @@ -41,6 +41,9 @@ public IndexDataMapProvider(DataMapSchemaStorageProvider storageProvider) {
       @Override
       public void initMeta(CarbonTable mainTable, DataMapSchema dataMapSchema, String ctasSqlStatement)
           throws MalformedDataMapCommandException, IOException {
    +    if (mainTable == null) {
    +      throw new MalformedDataMapCommandException("Parent table required to create index");
    --- End diff --
   
    change to `Parent table is required to create datamap`


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2122#discussion_r178422519
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala ---
    @@ -64,7 +64,7 @@ case class CarbonCreateDataMapCommand(
         }
     
         dataMapSchema = new DataMapSchema(dataMapName, dmClassName)
    -    if (mainTable.isStreamingTable &&
    +    if (mainTable != null && mainTable.isStreamingTable &&
    --- End diff --
   
    put ` mainTable.isStreamingTable` to next line


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2122
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4701/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2122
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3474/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2122
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4209/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2122
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2122


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2122
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3475/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2122
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4210/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2122
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4702/



---