Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2123#discussion_r178560655
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/impl/SearchModeVectorDetailQueryExecutor.java ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *
http://www.apache.org/licenses/LICENSE-2.0 + *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.carbondata.core.scan.executor.impl;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+
+import org.apache.carbondata.common.CarbonIterator;
+import org.apache.carbondata.common.logging.LogService;
+import org.apache.carbondata.common.logging.LogServiceFactory;
+import org.apache.carbondata.core.constants.CarbonCommonConstants;
+import org.apache.carbondata.core.scan.executor.exception.QueryExecutionException;
+import org.apache.carbondata.core.scan.executor.infos.BlockExecutionInfo;
+import org.apache.carbondata.core.scan.model.QueryModel;
+import org.apache.carbondata.core.scan.result.iterator.SearchModeResultIterator;
+import org.apache.carbondata.core.util.CarbonProperties;
+
+/**
+ * Below class will be used to execute the detail query and returns columnar vectors.
+ */
+public class SearchModeVectorDetailQueryExecutor extends AbstractQueryExecutor<Object> {
+ private static final LogService LOGGER =
+ LogServiceFactory.getLogService(SearchModeVectorDetailQueryExecutor.class.getName());
+ private static ExecutorService executorService;
+
+ static {
+ int nThread;
+ try {
+ nThread = Integer.parseInt(CarbonProperties.getInstance()
+ .getProperty(CarbonCommonConstants.CARBON_SEARCH_MODE_THREAD,
+ CarbonCommonConstants.CARBON_SEARCH_MODE_THREAD_DEFAULT));
+ } catch (NumberFormatException e) {
+ nThread = Integer.parseInt(CarbonCommonConstants.CARBON_SEARCH_MODE_THREAD_DEFAULT);
+ LOGGER.warn("The carbon.search.mode.thread is invalid. Using the default value " + nThread);
+ }
+ executorService = Executors.newFixedThreadPool(nThread);
--- End diff --
Why should we specify the #threads ?
Besides, since executorService is static, all SearchModeResultIterator will use the same pool. Is it intendedï¼
---
Locked
