[GitHub] carbondata pull request #2124: [CARBONDATA-2298]Delete segment lock files be...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2124: [CARBONDATA-2298]Delete segment lock files be...

qiuchenjian-2
GitHub user zzcclp opened a pull request:

    https://github.com/apache/carbondata/pull/2124

    [CARBONDATA-2298]Delete segment lock files before update metadata

    If there are some COMPACTED segments and their last modified time is within one hour, the segment lock files deletion operation will not be executed.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?  No
     
     - [ ] Any backward compatibility impacted?  No
     
     - [ ] Document update required?  No
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zzcclp/carbondata CARBONDATA-2298

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2124
   
----
commit fc9a72ab912f57e28b6431c73bdb97e0a07dbd46
Author: Zhang Zhichao <441586683@...>
Date:   2018-03-31T14:42:36Z

    [CARBONDATA-2298]Delete segment lock files before update metadata
   
    If there are some COMPACTED segments and their last modified time is within one hour, the segment lock files deletion operation will not be executed.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2124: [CARBONDATA-2298]Delete segment lock files before up...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2124
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3477/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2124: [CARBONDATA-2298]Delete segment lock files before up...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2124
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4704/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2124: [CARBONDATA-2298]Delete segment lock files before up...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2124
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4212/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2124: [CARBONDATA-2298]Delete segment lock files before up...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2124
 
    @jackylk @ravipesala @akashrn5 please help to review, thanks.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2124: [CARBONDATA-2298]Delete segment lock files before up...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2124
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2124: [CARBONDATA-2298]Delete segment lock files be...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2124


---