[GitHub] carbondata pull request #2126: [CARBONDATA-2300] Add ENABLE_UNSAFE_IN_QUERY_...

[qiuchenjian-2]

GitHub user chenliang613 opened a pull request:

    https://github.com/apache/carbondata/pull/2126

    [CARBONDATA-2300] Add ENABLE_UNSAFE_IN_QUERY_EXECUTION as a configuration parameter in presto integration

    Add ENABLE_UNSAFE_IN_QUERY_EXECUTION as a configuration parameter in presto integration
    Provide this configuration parameter for users to disable the unsafe in query execution.
   
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     NA
     - [X] Any backward compatibility impacted?
     YES
     - [X] Document update required?
    YES
     - [X] Testing done
    YES, Performance is better.
           
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    YES
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chenliang613/carbondata presto_unsafe

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2126
   
----
commit b86b421aabbbec9c19798a82b577d9114caaefb5
Author: chenliang613 <chenliang613@...>
Date:   2018-04-01T05:06:37Z

    [CARBONDATA-2300] Add ENABLE_UNSAFE_IN_QUERY_EXECUTION as a configuration parameter in presto integration

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2126
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3480/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2126
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4215/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2126
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4707/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2126#discussion_r178482124
 
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java ---
    @@ -372,6 +372,11 @@ public TBase create() {
           CarbonProperties.getInstance().addProperty(CarbonCommonConstants.UNSAFE_WORKING_MEMORY_IN_MB,
               config.getUnsafeMemoryInMb());
         }
    +    if(config.getEnableUnsafeInQueryExecution() != null) {
    +      CarbonProperties.getInstance()
    --- End diff --
   
    change the style to like
    ```
     CarbonProperties.getInstance().addProperty(
                 CarbonCommonConstants.ENABLE_UNSAFE_IN_QUERY_EXECUTION,
                 config.getEnableUnsafeInQueryExecution());
    ```


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2126
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3500/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2126
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4727/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2126
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4236/



---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2126#discussion_r178530872
 
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java ---
    @@ -372,6 +372,11 @@ public TBase create() {
           CarbonProperties.getInstance().addProperty(CarbonCommonConstants.UNSAFE_WORKING_MEMORY_IN_MB,
               config.getUnsafeMemoryInMb());
         }
    +    if(config.getEnableUnsafeInQueryExecution() != null) {
    +      CarbonProperties.getInstance()
    --- End diff --
   
    done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2126
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3522/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2126
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4749/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2126
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2126
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4753/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2126
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3526/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2126
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2126


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2126
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4255/



---