[GitHub] carbondata pull request #2130: [CARBONDATA-2302]Fix some bugs when separate ...

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2130: [CARBONDATA-2302]Fix some bugs when separate ...

qiuchenjian-2
GitHub user zzcclp opened a pull request:

    https://github.com/apache/carbondata/pull/2130

    [CARBONDATA-2302]Fix some bugs when separate visible and invisible segments info into two files

    There are some bugs where separate visible and invisible segments info into two files:
    1. It will not delete physical data of history segments after separating
    2. Generate duplicated segment id
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?  No
     
     - [ ] Any backward compatibility impacted?  No
     
     - [ ] Document update required?  No
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zzcclp/carbondata CARBONDATA-2302

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2130
   
----
commit 5aae4310110fb69f0def02654bb49a96fe606bf3
Author: Zhang Zhichao <441586683@...>
Date:   2018-04-01T17:09:52Z

    [CARBONDATA-2302]Fix some bugs when separate visible and invisible segments info into two files
   
    There are some bugs where separate visible and invisible segments info into two files:
    1. It will not delete physical data of history segments after separating
    2. Generate duplicated segment id

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2130: [CARBONDATA-2302]Fix some bugs when separate visible...

qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2130
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4227/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2130: [CARBONDATA-2302]Fix some bugs when separate visible...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2130
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3493/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2130: [CARBONDATA-2302]Fix some bugs when separate visible...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2130
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4720/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2130: [CARBONDATA-2302]Fix some bugs when separate visible...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2130
 
    retest sdv please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2130: [CARBONDATA-2302]Fix some bugs when separate visible...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2130
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4228/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2130: [CARBONDATA-2302]Fix some bugs when separate visible...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2130
 
    retest sdv please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2130: [CARBONDATA-2302]Fix some bugs when separate visible...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2130
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4229/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2130: [CARBONDATA-2302]Fix some bugs when separate visible...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2130
 
    retest sdv please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2130: [CARBONDATA-2302]Fix some bugs when separate visible...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2130
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4231/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2130: [CARBONDATA-2302]Fix some bugs when separate visible...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2130
 
    retest sdv please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2130: [CARBONDATA-2302]Fix some bugs when separate visible...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2130
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4233/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2130: [CARBONDATA-2302]Fix some bugs when separate visible...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2130
 
    retest sdv please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2130: [CARBONDATA-2302]Fix some bugs when separate visible...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2130
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4235/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2130: [CARBONDATA-2302]Fix some bugs when separate visible...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2130
 
    @ravipesala @jackylk  please review, thanks


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2130: [CARBONDATA-2302]Fix some bugs when separate visible...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2130
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2130: [CARBONDATA-2302]Fix some bugs when separate ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2130


---