[GitHub] carbondata pull request #2140: [CARBONDATA-2315] success and failure log fix...

[qiuchenjian-2]

GitHub user Indhumathi27 opened a pull request:

    https://github.com/apache/carbondata/pull/2140

    [CARBONDATA-2315] success and failure log fixed when no data is loaded into table

    Success and failure log fixed when no data is loaded into table
   
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Indhumathi27/carbondata load1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2140
   
----
commit 309dda3922bd3c0755e479fe878c48bb1e3e1add
Author: Indhumathi27 <indhumathim27@...>
Date:   2018-04-05T10:39:22Z

    [CARBONDATA-2315] success and failure log fixed when no data is loaded into table
   
     Please enter the commit message for your changes. Lines starting

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2140
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4841/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2140
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3617/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2140
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4311/



---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2140#discussion_r179661112
 
    --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
    @@ -493,18 +493,15 @@ object CarbonDataRDDFactory {
           }
           // as no record loaded in new segment, new segment should be deleted
           val newEntryLoadStatus =
    -      if (!carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable.isChildDataMap &&
    +        if (!carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable.isChildDataMap &&
               !CarbonLoaderUtil.isValidSegment(carbonLoadModel, carbonLoadModel.getSegmentId.toInt)) {
     
    -        LOGGER.audit(s"Data load is failed for " +
    -                     s"${ carbonLoadModel.getDatabaseName }.${ carbonLoadModel.getTableName }" +
    -                     " as there is no data to load")
    -        LOGGER.warn("Cannot write load metadata file as data load failed")
    +          LOGGER.warn("Cannot write load metadata file as there is no data to load")
     
    -        SegmentStatus.MARKED_FOR_DELETE
    -      } else {
    -        loadStatus
    -      }
    +          SegmentStatus.MARKED_FOR_DELETE
    +        } else {
    +          loadStatus
    +        }
    --- End diff --
   
    correct the formatting of code


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2140
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4850/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2140
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4319/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2140
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3628/



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2140
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2140


---