[GitHub] carbondata pull request #2143: [CARBONDATA-2317] oncurrent datamap with same...

[qiuchenjian-2]

GitHub user rahulforallp opened a pull request:

    https://github.com/apache/carbondata/pull/2143

    [CARBONDATA-2317] oncurrent datamap with same name and schema creation throws exception

    …n throws exception
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rahulforallp/incubator-carbondata concur_preagg

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2143
   
----
commit c82a046849562dc61b761f3aaefff1653f585a0f
Author: rahulforallp <rahul.kumar@...>
Date:   2018-04-06T09:47:54Z

    [CARBONDATA-2317] oncurrent datamap with same name and schema creation throws exception

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2143
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4853/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2143
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3631/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2143
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4322/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2143
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3648/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2143
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4870/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2143
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4339/



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2143
 
    Add a test case for this scenario. We have multiple test cases to test concurrency scenarios, you can take the reference from there


---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2143#discussion_r180315475
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonCreateTableCommand.scala ---
    @@ -121,21 +121,24 @@ case class CarbonCreateTableCommand(
               // isVisible property is added to hive table properties to differentiate between main
               // table and datamaps(like preaggregate). It is false only for datamaps. This is added
               // to improve the show tables performance when filtering the datamaps from main tables
    -          sparkSession.sql(
    -            s"""CREATE TABLE $dbName.$tableName
    -               |(${ rawSchema })
    -               |USING org.apache.spark.sql.CarbonSource
    -               |OPTIONS (
    -               |  tableName "$tableName",
    -               |  dbName "$dbName",
    -               |  tablePath "$tablePath",
    -               |  path "$tablePath",
    -               |  isExternal "$isExternal",
    -               |  isUnManaged "$isUnmanaged",
    -               |  isVisible "$isVisible"
    -               |  $carbonSchemaString)
    -               |  $partitionString
    +          // synchronized to prevent concurrently creation of table with same name
    +          CarbonCreateTableCommand.synchronized {
    --- End diff --
   
    CarbonCreateTableCommand is a case class and each thread will


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2143
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3686/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2143
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4909/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2143
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4375/



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2143
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2143


---