[GitHub] carbondata pull request #2144: [CARBONDATA-2319][Profiler] Fix carbon_scan_t...

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2144: [CARBONDATA-2319][Profiler] Fix carbon_scan_t...

qiuchenjian-2
GitHub user QiangCai opened a pull request:

    https://github.com/apache/carbondata/pull/2144

    [CARBONDATA-2319][Profiler] Fix carbon_scan_time and carbon_IO_time in task statistics

    carbon_scan_time and carbon_IO_time are incorrect in task statistics.
   
        +-------------+-------+-----------------------+----------+----------------+--------------------+----------------+--------------+---------------+---------------+---------------+-----------+-------------+-----------+-----------+
        |query_id     |task_id|start_time             |total_time|load_blocks_time|load_dictionary_time|carbon_scan_time|carbon_IO_time|scan_blocks_num|total_blocklets|valid_blocklets|total_pages|scanned_pages|valid_pages|result_size|
        +-------------+-------+-----------------------+----------+----------------+--------------------+----------------+--------------+---------------+---------------+---------------+-----------+-------------+-----------+-----------+
        |5385749464281|      0|2018-04-08 10:52:09.013|      47ms|             0ms|                 0ms|            -1ms|          -1ms|              1|              1|              1|          1|            0|          1|         10|
        +-------------+-------+-----------------------+----------+----------------+--------------------+----------------+--------------+---------------+---------------+---------------+-----------+-------------+-----------+-----------+
   
    This PR will fix these two items.
   
        +-------------+-------+-----------------------+----------+----------------+--------------------+----------------+--------------+---------------+---------------+---------------+-----------+-------------+-----------+-----------+
        |query_id     |task_id|start_time             |total_time|load_blocks_time|load_dictionary_time|carbon_scan_time|carbon_IO_time|scan_blocks_num|total_blocklets|valid_blocklets|total_pages|scanned_pages|valid_pages|result_size|
        +-------------+-------+-----------------------+----------+----------------+--------------------+----------------+--------------+---------------+---------------+---------------+-----------+-------------+-----------+-----------+
        |5479861175226|      0|2018-04-08 10:53:43.098|      52ms|             0ms|                 0ms|               1|             1|              1|              1|              1|          0|            1|          1|          1|
        +-------------+-------+-----------------------+----------+----------------+--------------------+----------------+--------------+---------------+---------------+---------------+-----------+-------------+-----------+-----------+
   
   
   
   
     - [x] Any interfaces changed?
     no
     - [x] Any backward compatibility impacted?
     yes
     - [x] Document update required?
    no
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    small


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/QiangCai/carbondata profiler_task_statistics

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2144
   
----
commit 952a65c6811b47fc32212abc3f344d8a018c4e3e
Author: QiangCai <qiangcai@...>
Date:   2018-04-08T03:01:00Z

    fix carbon_scan_time and carbon_IO_time in task statistics

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2144: [CARBONDATA-2319][Profiler] Fix carbon_scan_time and...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2144
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3633/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2144: [CARBONDATA-2319][Profiler] Fix carbon_scan_time and...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2144
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4324/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2144: [CARBONDATA-2319][Profiler] Fix carbon_scan_time and...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2144
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4855/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2144: [CARBONDATA-2319][Profiler] Fix carbon_scan_time and...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2144
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2144: [CARBONDATA-2319][Profiler] Fix carbon_scan_t...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2144


---