[GitHub] carbondata pull request #2154: [WIP] Non Serializable extra info in session ...

[qiuchenjian-2]

GitHub user KanakaKumar opened a pull request:

    https://github.com/apache/carbondata/pull/2154

    [WIP] Non Serializable extra info in session is overwritten from stale thread

    Problem:
             1. Non Serializable extra info is copied from thread which causes stale data from old session when the thread is reused by spark.
             2. CarboSessionInfo clone is not copying Non serializable info to new object which can damage session level values if local query thread updates values.
   
    Solution: Remove logic to copy Non Serializable extra info and fix clone logic
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    No
     - [ ] Testing done
            Tested in local cluster      
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/KanakaKumar/carbondata master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2154
   
----
commit 1cfabf53226ddfe1143359de24ddbbc75cdf396b
Author: KanakaKumar <kanaka.avvaru@...>
Date:   2018-04-10T14:12:30Z

    Problem: 1. Non Serializable extra info is copied from thread which causes stale data from old session when the thread is reused by spark.
             2. CarboSessionInfo clone is not copying Non serializable info to new object which can damage session level values if local query thread updates values.
   
    Solution: Remove logic to copy Non Serializable extra info and fix clone logic

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2154
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3703/



---

[qiuchenjian-2]

Github user KanakaKumar commented on the issue:

    https://github.com/apache/carbondata/pull/2154
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2154
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4924/



---

[qiuchenjian-2]

Github user KanakaKumar commented on the issue:

    https://github.com/apache/carbondata/pull/2154
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2154
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3707/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2154
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4928/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2154
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3709/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2154
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4389/



---

[qiuchenjian-2]

Github user KanakaKumar commented on the issue:

    https://github.com/apache/carbondata/pull/2154
 
    retest this please


---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2154#discussion_r180638168
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonSessionInfo.java ---
    @@ -60,11 +60,9 @@ public CarbonSessionInfo clone() throws CloneNotSupportedException {
         CarbonSessionInfo newObj = new CarbonSessionInfo();
         newObj.setSessionParams(sessionParams.clone());
         newObj.setThreadParams(threadParams.clone());
    -    Map<String, Object> nonSerializableExtraInfo = getNonSerializableExtraInfo();
    -    for (Map.Entry<String, Object> entry : nonSerializableExtraInfo.entrySet()) {
    -      nonSerializableExtraInfo.put(entry.getKey(), entry.getValue());
    +    for (Map.Entry<String, Object> entry : getNonSerializableExtraInfo().entrySet()) {
    +      newObj.nonSerializableExtraInfo.put(entry.getKey(), entry.getValue());
    --- End diff --
   
    here it should be newObj.getNonSerializableExtraInfo().put as nonSerializableExtraInfo is initialized only in the get method


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2154
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3711/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2154
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4930/



---

[qiuchenjian-2]

Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2154#discussion_r180655982
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonSessionInfo.java ---
    @@ -60,11 +60,9 @@ public CarbonSessionInfo clone() throws CloneNotSupportedException {
         CarbonSessionInfo newObj = new CarbonSessionInfo();
         newObj.setSessionParams(sessionParams.clone());
         newObj.setThreadParams(threadParams.clone());
    -    Map<String, Object> nonSerializableExtraInfo = getNonSerializableExtraInfo();
    -    for (Map.Entry<String, Object> entry : nonSerializableExtraInfo.entrySet()) {
    -      nonSerializableExtraInfo.put(entry.getKey(), entry.getValue());
    +    for (Map.Entry<String, Object> entry : getNonSerializableExtraInfo().entrySet()) {
    +      newObj.nonSerializableExtraInfo.put(entry.getKey(), entry.getValue());
    --- End diff --
   
    Fixed.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2154
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4936/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2154
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3717/



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2154
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2154


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2154
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4397/



---