[GitHub] carbondata pull request #2172: [CARBONDATA-2333] Block insert overwrite if a...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5225/



---

[qiuchenjian-2]

Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2172#discussion_r182956717
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala ---
    @@ -73,18 +74,9 @@ case class PreAggregateTableHelper(
           Seq()
         }
         // Generate child table partition columns in the same order as the parent table.
    -    val partitionerFields = fieldRelationMap.collect {
    -      case (field, dataMapField) if parentPartitionColumns
    -        .exists(parentCol =>
    -          /* For count(*) while Pre-Aggregate table creation,columnTableRelationList was null */
    -          dataMapField.columnTableRelationList.getOrElse(Seq()).nonEmpty &&
    -            parentCol.equals(dataMapField.columnTableRelationList.get.head.parentColumnName) &&
    -          dataMapField.aggregateFunction.isEmpty) =>
    -        (PartitionerField(field.name.get,
    -          field.dataType,
    -          field.columnComment), parentPartitionColumns
    -          .indexOf(dataMapField.columnTableRelationList.get.head.parentColumnName))
    -    }.toSeq.sortBy(_._2).map(_._1)
    +    val partitionerFields =
    +      PartitionUtils.getPartitionerFields(parentPartitionColumns, fieldRelationMap)
    --- End diff --
   
    fixed


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4047/



---

[qiuchenjian-2]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2172#discussion_r183012262
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala ---
    @@ -73,18 +74,9 @@ case class PreAggregateTableHelper(
           Seq()
         }
         // Generate child table partition columns in the same order as the parent table.
    -    val partitionerFields = fieldRelationMap.collect {
    -      case (field, dataMapField) if parentPartitionColumns
    -        .exists(parentCol =>
    -          /* For count(*) while Pre-Aggregate table creation,columnTableRelationList was null */
    -          dataMapField.columnTableRelationList.getOrElse(Seq()).nonEmpty &&
    -            parentCol.equals(dataMapField.columnTableRelationList.get.head.parentColumnName) &&
    -          dataMapField.aggregateFunction.isEmpty) =>
    -        (PartitionerField(field.name.get,
    -          field.dataType,
    -          field.columnComment), parentPartitionColumns
    -          .indexOf(dataMapField.columnTableRelationList.get.head.parentColumnName))
    -    }.toSeq.sortBy(_._2).map(_._1)
    +    val partitionerFields =
    +      PartitionUtils.getPartitionerFields(parentPartitionColumns, fieldRelationMap)
    --- End diff --
   
    fixed


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4057/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5247/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4449/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4143/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5326/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4159/



---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5340/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4170/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4181/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5360/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5416/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4248/



---