[GitHub] carbondata pull request #2172: [CARBONDATA-2333] Block insert overwrite if a...

[qiuchenjian-2]

GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/2172

    [CARBONDATA-2333] Block insert overwrite if all partition columns are not present in an…

    …y one of the datamaps
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata preagg_partition_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2172
   
----
commit 5c53f555d3a46b1a0961b7eb82e7ba5df628e994
Author: kunal642 <kunalkapoor642@...>
Date:   2018-04-11T11:22:08Z

    block insert overwrite if all partition columns are not present in any one of the datamaps

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3789/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5005/



---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5020/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3804/



---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5040/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3823/



---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    retest this please


---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Please update PR description


---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2172#discussion_r181770149
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/util/PartitionUtils.scala ---
    @@ -223,4 +224,41 @@ object PartitionUtils {
           }
         }
       }
    +
    +  /**
    +   * Used to extract Partitioner Fields for aggregation datamaps.
    +   *
    +   */
    +  def getPartitionerFields(partitionColumn: Seq[String],
    --- End diff --
   
    Please add detail level comment for this method,
    Condition for generating partition filed


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3845/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5067/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3853/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5075/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5090/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3871/



---

[qiuchenjian-2]

Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2172#discussion_r182136155
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala ---
    @@ -73,18 +74,9 @@ case class PreAggregateTableHelper(
           Seq()
         }
         // Generate child table partition columns in the same order as the parent table.
    -    val partitionerFields = fieldRelationMap.collect {
    -      case (field, dataMapField) if parentPartitionColumns
    -        .exists(parentCol =>
    -          /* For count(*) while Pre-Aggregate table creation,columnTableRelationList was null */
    -          dataMapField.columnTableRelationList.getOrElse(Seq()).nonEmpty &&
    -            parentCol.equals(dataMapField.columnTableRelationList.get.head.parentColumnName) &&
    -          dataMapField.aggregateFunction.isEmpty) =>
    -        (PartitionerField(field.name.get,
    -          field.dataType,
    -          field.columnComment), parentPartitionColumns
    -          .indexOf(dataMapField.columnTableRelationList.get.head.parentColumnName))
    -    }.toSeq.sortBy(_._2).map(_._1)
    +    val partitionerFields =
    +      PartitionUtils.getPartitionerFields(parentPartitionColumns, fieldRelationMap)
    --- End diff --
   
     dataMapField.columnTableRelationList.getOrElse(Seq()).nonEmpty &&
   
    This empty check was added in #2170 is not considered during method extraction.  Please fix


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2172
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3940/



---