[GitHub] carbondata pull request #2187: [CARBONDATA-2362] Changing the Cacheable obje...

[qiuchenjian-2]

GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/2187

    [CARBONDATA-2362] Changing the Cacheable object from DataMap to Wrapper

    (1) Cacheable object is changed from dataMap to wrapper
    (2) Blocklet info is stored as binary to dataMap
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [x] Testing done
            Manual Testing
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/carbondata optimizations_cache

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2187
   
----
commit 889b90c6e99762f55fb42a516733bc38590f4cfd
Author: dhatchayani <dhatcha.official@...>
Date:   2018-04-19T07:18:15Z

    [CARBONDATA-2362] Changing the Cacheable object from DataMap to Wrapper

----


---

[qiuchenjian-2]

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2187
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2187
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4022/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2187
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5216/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2187#discussion_r182936215
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java ---
    @@ -978,15 +968,6 @@ public long getMemorySize() {
         return memoryUsed;
       }
     
    -  public TableBlockIndexUniqueIdentifier getTableBlockUniqueIdentifier() {
    --- End diff --
   
    Now is it required this class to implement Cacheable?


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2187#discussion_r182937925
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDetailInfo.java ---
    @@ -50,6 +49,8 @@
     
       private BlockletInfo blockletInfo;
    --- End diff --
   
    I think it should be transient


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2187#discussion_r182937969
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDetailInfo.java ---
    @@ -83,6 +84,22 @@ public void setVersionNumber(short versionNumber) {
       }
     
       public BlockletInfo getBlockletInfo() {
    +    if (null == blockletInfo && null != blockletInfoBinary && blockletInfoBinary.length > 0) {
    +      blockletInfo = new BlockletInfo();
    +      ByteArrayInputStream stream = new ByteArrayInputStream(blockletInfoBinary);
    +      DataInputStream inputStream = new DataInputStream(stream);
    +      try {
    +        blockletInfo.readFields(inputStream);
    +      } catch (IOException e) {
    +        e.printStackTrace();
    --- End diff --
   
    remove it and throw exception


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2187#discussion_r182937982
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDetailInfo.java ---
    @@ -83,6 +84,22 @@ public void setVersionNumber(short versionNumber) {
       }
     
       public BlockletInfo getBlockletInfo() {
    +    if (null == blockletInfo && null != blockletInfoBinary && blockletInfoBinary.length > 0) {
    +      blockletInfo = new BlockletInfo();
    +      ByteArrayInputStream stream = new ByteArrayInputStream(blockletInfoBinary);
    +      DataInputStream inputStream = new DataInputStream(stream);
    +      try {
    +        blockletInfo.readFields(inputStream);
    +      } catch (IOException e) {
    +        e.printStackTrace();
    +      } finally {
    +        try {
    +          inputStream.close();
    +        } catch (IOException e) {
    +          e.printStackTrace();
    --- End diff --
   
    remove it and throw exception


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2187
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4044/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2187
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5233/



---

[qiuchenjian-2]

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2187
 
    Retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2187
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4127/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2187
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5307/



---

[qiuchenjian-2]

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2187
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2187
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4141/



---

[qiuchenjian-2]

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2187
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2187
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5324/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2187
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4156/



---

[qiuchenjian-2]

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2187
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2187
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5337/



---