[GitHub] carbondata pull request #2203: [WIP] Fix issue in datamap for multiple block...

[qiuchenjian-2]

GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/2203

    [WIP] Fix issue in datamap for multiple blocklets across blocks

    It is a rough fix, just give an idea of how to fix it.
   
    Current datamap writing is mapped between block to blockletid, instead of that we can map to carbonindex to blockletid, In this way, we can avoid the extra mappings in datInstead amaps while reading. And it eases during writing as datamap can completly eliminate the block concept in it.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata pr-2201

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2203.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2203
   
----
commit 343b275bc0de1eb7ee4c14f58cc4a84f13204828
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-04-21T06:22:37Z

    Fix errors in minmax datamap example

commit 4e46fbccd4bc4476893d4ac7d01e14b936545832
Author: ravipesala <ravi.pesala@...>
Date:   2018-04-21T10:34:59Z

    wip

commit e26eb388355fef26e032b2185a7f08d327e4c3f3
Author: ravipesala <ravi.pesala@...>
Date:   2018-04-21T11:46:29Z

    wip fix for multiple blocklets datamap issue

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2203
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4099/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2203
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5279/



---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2203#discussion_r183210244
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java ---
    @@ -266,7 +266,7 @@ private void notifyDataMapBlockEnd() {
             throw new CarbonDataWriterException("Problem while writing datamap", e);
           }
         }
    -    blockletId = 0;
    +//    blockletId = 0;
    --- End diff --
   
    This may also raise a checkstyle error.


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2203#discussion_r183210246
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java ---
    @@ -145,7 +145,7 @@ public ExtendedBlocklet getExtendedBlocklet(Blocklet blocklet, Segment segment)
     
       private ExtendedBlocklet getExtendedBlocklet(List<TableBlockIndexUniqueIdentifier> identifiers,
           Blocklet blocklet) throws IOException {
    -    String carbonIndexFileName = CarbonTablePath.getCarbonIndexFileName(blocklet.getBlockId());
    +    String carbonIndexFileName = blocklet.getBlockId();//CarbonTablePath.getCarbonIndexFileName(blocklet.getBlockId());
    --- End diff --
   
    maybe the line is too long, checkstyle won't pass


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2203
 
    Proper implementation is done in PR https://github.com/apache/carbondata/pull/2206 . So closing this PR


---

[qiuchenjian-2]

Github user ravipesala closed the pull request at:

    https://github.com/apache/carbondata/pull/2203


---