[GitHub] carbondata pull request #2207: [WIP] Support flat folder for managed carbon ...

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4687/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5613/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4452/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4706/



---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2207#discussion_r186599210
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ---
    @@ -140,15 +141,19 @@ public static String genSegmentFileName(String segmentId, String UUID) {
     
       /**
        * Write segment file to the metadata folder of the table
    +   *
        * @param tablePath table path
        * @param segmentId segment id
    -   * @param UUID a UUID string used to construct the segment file name
    +   * @param UUID      a UUID string used to construct the segment file name
        * @return segment file name
        */
       public static String writeSegmentFile(String tablePath, String segmentId, String UUID)
           throws IOException {
         String segmentPath = CarbonTablePath.getSegmentPath(tablePath, segmentId);
         CarbonFile segmentFolder = FileFactory.getCarbonFile(segmentPath);
    +    boolean supportFlatFolder = Boolean.parseBoolean(CarbonProperties.getInstance()
    --- End diff --
   
    I think this property should be in CreateTable-TBLProperties instead of in CarbonProperty. Otherwise, user may change the configuration in separate data loading.



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Currently `segment` is a key terminology in carbon. The compaction/update/streaming.. all rely on the management of segment. will happen to the `flat folder` carbon table for the above scenario?



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6190/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5029/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5164/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6200/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5039/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5174/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    please check SDV


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5221/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6251/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5089/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5228/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5096/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6258/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5231/



---