[GitHub] carbondata pull request #2207: [WIP] Support flat folder for managed carbon ...

[qiuchenjian-2]

GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/2207

    [WIP] Support flat folder for managed carbon table

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata no-segment-folder

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2207.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2207
   
----
commit d62c8d00051d785ddbabe4370e8a865d482174b8
Author: ravipesala <ravi.pesala@...>
Date:   2018-04-20T02:04:00Z

    Support flat folder

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4116/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5297/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2207#discussion_r183230258
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/CompactionSupportGlobalSortBigFileTest.scala ---
    @@ -72,8 +72,8 @@ class CompactionSupportGlobalSortBigFileTest extends QueryTest with BeforeAndAft
       }
     
       override def afterEach {
    -    sql("DROP TABLE IF EXISTS compaction_globalsort")
    -    sql("DROP TABLE IF EXISTS carbon_localsort")
    +//    sql("DROP TABLE IF EXISTS compaction_globalsort")
    --- End diff --
   
    please remove if not required


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4236/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5403/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4542/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4302/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5469/



---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2207#discussion_r184838170
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ---
    @@ -140,15 +141,19 @@ public static String genSegmentFileName(String segmentId, String UUID) {
     
       /**
        * Write segment file to the metadata folder of the table
    +   *
        * @param tablePath table path
        * @param segmentId segment id
    -   * @param UUID a UUID string used to construct the segment file name
    --- End diff --
   
    please keep it


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2207#discussion_r184838441
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ---
    @@ -162,21 +167,44 @@ public static String writeSegmentFile(String tablePath, String segmentId, String
           for (CarbonFile file : indexFiles) {
             folderDetails.getFiles().add(file.getName());
           }
    -      String segmentRelativePath = segmentPath.substring(tablePath.length(), segmentPath.length());
    +      String segmentRelativePath = "/";
    +      if (!supportFlatFolder) {
    +        segmentRelativePath = segmentPath.substring(tablePath.length(), segmentPath.length());
    +      }
           segmentFile.addPath(segmentRelativePath, folderDetails);
    -      String segmentFileFolder =  CarbonTablePath.getSegmentFilesLocation(tablePath);
    +      String segmentFileFolder = CarbonTablePath.getSegmentFilesLocation(tablePath);
           CarbonFile carbonFile = FileFactory.getCarbonFile(segmentFileFolder);
           if (!carbonFile.exists()) {
             carbonFile.mkdirs(segmentFileFolder, FileFactory.getFileType(segmentFileFolder));
           }
           String segmentFileName = genSegmentFileName(segmentId, UUID) + CarbonTablePath.SEGMENT_EXT;
           // write segment info to new file.
           writeSegmentFile(segmentFile, segmentFileFolder + File.separator + segmentFileName);
    +
    +      // Move all files to table path from segment folder.
    +      if (supportFlatFolder) {
    +        moveFromTempFolder(segmentPath, tablePath);
    +      }
    +
           return segmentFileName;
         }
         return null;
       }
     
    +  /**
    +   * Move the loaded data from temp folder to respective partition folder.
    +   * @param tablePath
    --- End diff --
   
    Please add segmentPath and related  describe


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2207#discussion_r184838574
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java ---
    @@ -80,18 +80,18 @@ public static String getSegmentWithBlockFromTID(String Tid) {
        * Returns block path from tuple id
        *
        * @param tid
    -   * @param factPath
    +   * @param tablePath
    --- End diff --
   
    Please add isSegmentFile and related describe


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Please add describe for this PR


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2207#discussion_r184839053
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/DeleteExecution.scala ---
    @@ -114,6 +109,10 @@ object DeleteExecution {
         CarbonUpdateUtil
           .createBlockDetailsMap(blockMappingVO, segmentUpdateStatusMngr)
     
    +    val metadataDetails = SegmentStatusManager.readTableStatusFile(
    +      CarbonTablePath.getTableStatusFilePath(carbonTable.getTablePath))
    +
    +
    --- End diff --
   
    please remove this blank line


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2207#discussion_r184839135
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/DeleteExecution.scala ---
    @@ -127,12 +126,16 @@ object DeleteExecution {
               var result = List[(SegmentStatus, (SegmentUpdateDetails, ExecutionErrors))]()
               while (records.hasNext) {
                 val ((key), (rowCountDetailsVO, groupedRows)) = records.next
    +            val segmentId = key.substring(0, key.indexOf(CarbonCommonConstants.FILE_SEPARATOR))
    --- End diff --
   
    Is it possible that return -1 when run key.indexOf?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5515/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4350/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4351/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4616/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2207
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5516/



---