[GitHub] carbondata pull request #2209: [WIP][Non Transactional Table]Avro Record Com...

[qiuchenjian-2]

GitHub user sounakr opened a pull request:

    https://github.com/apache/carbondata/pull/2209

    [WIP][Non Transactional Table]Avro Record Complex Type Implementation

    Avro Complex DataType Support.
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sounakr/incubator-carbondata avro-datatype

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2209
   
----
commit 464ade68ca1d45a4fcac15c070b7edae8838bff7
Author: sounakr <sounakr@...>
Date:   2018-04-23T04:48:10Z

    Avro Record Complex Type Implementation

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4138/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5319/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    Please modify the PR title, it is for SDK, change to [SDK]


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5510/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4345/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4611/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4354/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5518/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4620/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4621/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4355/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5519/



---

[qiuchenjian-2]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2209#discussion_r184904922
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala ---
    @@ -175,9 +175,31 @@ class TestNonTransactionalCarbonTable extends QueryTest with BeforeAndAfterAll {
     
       test("test create External Table with Schema with partition, should ignore schema and partition")
       {
    -    buildTestDataSingleFile()
    +    sql("DROP TABLE IF EXISTS sdkOutputTable")
    +
    +    // with partition
    +    sql("CREATE EXTERNAL TABLE sdkOutputTable(name string) PARTITIONED BY (age int) STORED BY 'carbondata' LOCATION '/home/root1/avro/files' ")
    +//
    +//    checkAnswer(sql("select * from sdkOutputTable"), Seq(Row("robot0", 0, 0.0),
    +//      Row("robot1", 1, 0.5),
    +//      Row("robot2", 2, 1.0)))
    --- End diff --
   
    please revert back this test case and add new one


---

[qiuchenjian-2]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2209#discussion_r184905554
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/SchemaReader.java ---
    @@ -81,10 +81,13 @@ public static TableInfo getTableInfo(AbsoluteTableIdentifier identifier)
       }
     
       public static TableInfo inferSchema(AbsoluteTableIdentifier identifier,
    -      boolean isCarbonFileProvider) throws IOException {
    +      boolean isCarbonFileProvider, TableInfo tableInfoFromCache) throws IOException {
         // This routine is going to infer schema from the carbondata file footer
         // Convert the ColumnSchema -> TableSchema -> TableInfo.
         // Return the TableInfo.
    +    if (tableInfoFromCache != null) {
    --- End diff --
   
    If tableInfoFromCache is found, No need to call inferschema itself, please handle this outside infer schema


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4622/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4357/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5521/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4623/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2209
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4624/



---