[GitHub] carbondata pull request #2228: WIP:[CARBONDATA-2402] Optimize allocated buff...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2228: WIP:[CARBONDATA-2402] Optimize allocated buff...

qiuchenjian-2
GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2228

    WIP:[CARBONDATA-2402] Optimize allocated buffer size for converting objects

    Currently while converting objects to byte array, for value of int/short, reduce allocated buffer size from 8 bytes to 4/2 respectively.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     `NO`
     - [x] Any backward compatibility impacted?
     `Not sure`
     - [x] Document update required?
    `NO`
     - [] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0425_bug_datatype_bytes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2228.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2228
   
----
commit 94e9ee9f52eefa21f6003cc6f99f173e935a4994
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-04-25T13:06:34Z

    Optimize allocated buffer size for converting objects
   
    Currently while converting objects to byte array, for value of int/short, reduce allocated buffer size from 8 bytes to 4/2 respectively.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2228: WIP:[CARBONDATA-2402] Optimize allocated buffer size...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2228
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4230/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2228: WIP:[CARBONDATA-2402] Optimize allocated buffer size...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2228
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5397/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2228: WIP:[CARBONDATA-2402] Optimize allocated buffer size...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2228
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4536/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2228: WIP:[CARBONDATA-2402] Optimize allocated buff...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xuchuanyin closed the pull request at:

    https://github.com/apache/carbondata/pull/2228


---