[GitHub] carbondata pull request #2240: [CARBONDATA-2313] fixed multiple issues in SD...

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2240: [CARBONDATA-2313] fixed multiple issues in SD...

qiuchenjian-2
GitHub user ajantha-bhat opened a pull request:

    https://github.com/apache/carbondata/pull/2240

    [CARBONDATA-2313] fixed multiple issues in SDK writer and external table with NonTransactional table data

    [CARBONDATA-2313] fixed multiple issues in SDK writer and external table with NonTransactional table data
   
    *Header update for sdk interface api.
    *bad record path issue in sdk writer, should not be "null/null/null/taskno" changed to "sdkBadRecords/taskno".
    *Non transactional table, Number format exception was coming instead of bad record exception when load fails due to bad record.
    *Non transactional table, insert overwrite failure case old files must not be deleted.
    *Non transactional table, describe formatted path should be files path.
    *SDK, default all dimensions munst be inverted index encoding.
    *SDK, avro not supporting float datatype.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?No
     
     - [ ] Any backward compatibility impacted?No
     
     - [ ] Document update required?NA
   
     - [ ] Testing done
            updated UT test cases.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.  NA
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ajantha-bhat/carbondata unmanaged_table

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2240.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2240
   
----
commit afe1781a268a45e03072fc319ea214b1e580fbd4
Author: ajantha-bhat <ajanthabhat@...>
Date:   2018-04-23T10:47:29Z

    [CARBONDATA-2313] fixed muliple issues in SKD writer and external table with nonTransactional table data
   
    *Header update for sdk interface api
    *bad record path issue in sdk writer, should not be "null/null/null/taskno" changed to "sdkBadRecords/taskno"
    *Non transactional table, Number format exception was coming instead of bad record exception when load fails due to bad record
    *Non transactional table, insert overwrite failure case old files must not be deleted
    *Non transactional table, describe formatted path should be files path
    *SDK, default all dimensions munst be inverted index encoding
    *SDK, avro not supporting float datatype

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2240: [CARBONDATA-2313] fixed multiple issues in SDK write...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2240
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4295/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2240: [CARBONDATA-2313] fixed multiple issues in SDK write...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2240
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5461/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2240: [CARBONDATA-2313] fixed multiple issues in SDK write...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/2240
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2240: [CARBONDATA-2313] fixed multiple issues in SDK write...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2240
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4317/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2240: [CARBONDATA-2313] fixed multiple issues in SDK write...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2240
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5483/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2240: [CARBONDATA-2313] fixed multiple issues in SDK write...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2240
 
    Many places indentation is not correct, please check


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2240: [CARBONDATA-2313] fixed multiple issues in SDK write...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2240
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4634/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2240: [CARBONDATA-2313] fixed multiple issues in SDK write...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2240
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5538/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2240: [CARBONDATA-2313] fixed multiple issues in SDK write...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2240
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4375/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2240: [CARBONDATA-2313] fixed multiple issues in SDK write...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/2240
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2240: [CARBONDATA-2313] fixed multiple issues in SDK write...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2240
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5545/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2240: [CARBONDATA-2313] fixed multiple issues in SDK write...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2240
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4382/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2240: [CARBONDATA-2313] fixed multiple issues in SDK write...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2240
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2240: [CARBONDATA-2313] fixed multiple issues in SD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2240


---