[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5931/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4776/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5934/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4779/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4963/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4964/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2246#discussion_r188972807
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java ---
    @@ -175,6 +175,18 @@ public DiskBasedDMSchemaStorageProvider(String storePath) {
         }
       }
     
    +  private void checkAndReloadDataMapSchemasWithoutNewFile() throws IOException {
    --- End diff --
   
    It is duplicated to below method, just pass boolean to handle in below method instead of duplicating it


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2246#discussion_r189142890
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java ---
    @@ -175,6 +175,18 @@ public DiskBasedDMSchemaStorageProvider(String storePath) {
         }
       }
     
    +  private void checkAndReloadDataMapSchemasWithoutNewFile() throws IOException {
    --- End diff --
   
    ok, done


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4983/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5952/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4796/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4801/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5958/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2246#discussion_r189223250
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java ---
    @@ -103,7 +103,7 @@ public DiskBasedDMSchemaStorageProvider(String storePath) {
       }
     
       @Override public List<DataMapSchema> retrieveSchemas(CarbonTable carbonTable) throws IOException {
    -    checkAndReloadDataMapSchemas();
    +    checkAndReloadDataMapSchemas(false);
    --- End diff --
   
    In case carbon table is non transactional don't touchFile


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2246#discussion_r189318314
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java ---
    @@ -103,7 +103,7 @@ public DiskBasedDMSchemaStorageProvider(String storePath) {
       }
     
       @Override public List<DataMapSchema> retrieveSchemas(CarbonTable carbonTable) throws IOException {
    -    checkAndReloadDataMapSchemas();
    +    checkAndReloadDataMapSchemas(false);
    --- End diff --
   
    retrieveSchemas no need touch md file


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2246#discussion_r189421336
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java ---
    @@ -103,7 +103,7 @@ public DiskBasedDMSchemaStorageProvider(String storePath) {
       }
     
       @Override public List<DataMapSchema> retrieveSchemas(CarbonTable carbonTable) throws IOException {
    -    checkAndReloadDataMapSchemas();
    +    checkAndReloadDataMapSchemas(false);
    --- End diff --
   
    I think you need to decide the true of false based on the `carbonTable.isTransactionalTable`


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2246#discussion_r189422726
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java ---
    @@ -103,7 +103,7 @@ public DiskBasedDMSchemaStorageProvider(String storePath) {
       }
     
       @Override public List<DataMapSchema> retrieveSchemas(CarbonTable carbonTable) throws IOException {
    -    checkAndReloadDataMapSchemas();
    +    checkAndReloadDataMapSchemas(false);
    --- End diff --
   
    I think,  it is not required to touch the md file in case of retrieve


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2246


---