[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

[qiuchenjian-2]

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/2246

    [CARBONDATA-2413] After running CarbonWriter, there is null/_system directory about datamap

   
    change the system folder location property, which will change the system location of datamap
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA-2413-remove-null

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2246
   
----
commit 99c09dbedc8dc054616381d9811d4185adb5c170
Author: xubo245 <601450868@...>
Date:   2018-04-28T03:09:24Z

    [CARBONDATA-2413] After running CarbonWriter, there is null directory about datamap
   
    change the system folder location property, which will change the system location of datamap

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4592/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5491/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4325/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4601/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4606/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    @ravipesala @jackylk @QiangCai Can you help to review it?


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2246#discussion_r185716301
 
    --- Diff: store/sdk/src/test/java/org/apache/carbondata/store/LocalCarbonStoreTest.java ---
    @@ -28,9 +28,16 @@
     import org.apache.carbondata.sdk.file.TestUtil;
     
     import org.apache.commons.io.FileUtils;
    +import org.junit.Before;
     import org.junit.Test;
     
    +import static org.apache.carbondata.sdk.file.TestUtil.setSystemLocation;
    +
     public class LocalCarbonStoreTest {
    +  @Before
    +  public void test() {
    +    setSystemLocation();
    --- End diff --
   
    You should set it back to null after the testcase


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5739/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4581/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2246#discussion_r186921137
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java ---
    @@ -259,14 +259,16 @@ public static CarbonFactDataHandlerModel createCarbonFactDataHandlerModel(
         carbonFactDataHandlerModel.sortScope = CarbonDataProcessorUtil.getSortScope(configuration);
     
         DataMapWriterListener listener = new DataMapWriterListener();
    -    listener.registerAllWriter(
    -        configuration.getTableSpec().getCarbonTable(),
    -        configuration.getSegmentId(),
    -        CarbonTablePath.getShardName(
    -            carbonDataFileAttributes.getTaskId(),
    -            bucketId,
    -            0,
    -            String.valueOf(carbonDataFileAttributes.getFactTimeStamp())));
    +    if (null != configuration.getSegmentId()) {
    +      listener.registerAllWriter(
    --- End diff --
   
    add a comment for this. SDK currently does not support writing datamap


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4810/



---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2246#discussion_r186923021
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java ---
    @@ -259,14 +259,16 @@ public static CarbonFactDataHandlerModel createCarbonFactDataHandlerModel(
         carbonFactDataHandlerModel.sortScope = CarbonDataProcessorUtil.getSortScope(configuration);
     
         DataMapWriterListener listener = new DataMapWriterListener();
    -    listener.registerAllWriter(
    -        configuration.getTableSpec().getCarbonTable(),
    -        configuration.getSegmentId(),
    -        CarbonTablePath.getShardName(
    -            carbonDataFileAttributes.getTaskId(),
    -            bucketId,
    -            0,
    -            String.valueOf(carbonDataFileAttributes.getFactTimeStamp())));
    +    if (null != configuration.getSegmentId()) {
    +      listener.registerAllWriter(
    --- End diff --
   
    ok, done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4592/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5751/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4813/



---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2246#discussion_r186940468
 
    --- Diff: store/sdk/src/test/java/org/apache/carbondata/store/LocalCarbonStoreTest.java ---
    @@ -28,9 +28,16 @@
     import org.apache.carbondata.sdk.file.TestUtil;
     
     import org.apache.commons.io.FileUtils;
    +import org.junit.Before;
     import org.junit.Test;
     
    +import static org.apache.carbondata.sdk.file.TestUtil.setSystemLocation;
    +
     public class LocalCarbonStoreTest {
    +  @Before
    +  public void test() {
    +    setSystemLocation();
    --- End diff --
   
    ok, changed


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2246
 
    retest this please


---