[GitHub] carbondata pull request #2260: [CarbonData-2427] Fix SearchMode Serializatio...

[qiuchenjian-2]

GitHub user Indhumathi27 opened a pull request:

    https://github.com/apache/carbondata/pull/2260

    [CarbonData-2427]  Fix SearchMode Serialization Issue during Load

   
     - [x] Any interfaces changed?
           NA
     - [x] Any backward compatibility impacted?
           NA
     - [x] Document update required?
           NA
     - [x] Testing done
           NA
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
           NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Indhumathi27/carbondata searchmode

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2260.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2260
   
----
commit c25992e487d7258b37e3ceaf700daa9c460dabeb
Author: Indhumathi27 <indhumathim27@...>
Date:   2018-05-02T14:22:50Z

    Fix Serialization issue in Search mode

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2260
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4429/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2260
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5590/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2260
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4685/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2260
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2260


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2260#discussion_r185686357
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -177,7 +177,7 @@ class CarbonSession(@transient val sc: SparkContext,
         }
       }
     
    -  private var carbonStore: SparkCarbonStore = _
    +  @transient private var carbonStore: SparkCarbonStore = _
    --- End diff --
   
    Can you try to add "extends Serializable" for  SparkCarbonStore  or parent class instead of "using transient"?


---