Apache CarbonData Dev Mailing List archive › Apache CarbonData JIRA issues

[GitHub] carbondata pull request #2270: [CARBONDATA-2438][Build] Remove hadoop/spark/...

Classic

List

Threaded

8 messages Options

qiuchenjian-2

[GitHub] carbondata pull request #2270: [CARBONDATA-2438][Build] Remove hadoop/spark/...

GitHub user xuchuanyin opened a pull request:

https://github.com/apache/carbondata/pull/2270

[CARBONDATA-2438][Build] Remove hadoop/spark/zookeeper related classes from assembly

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

- [x] Any interfaces changed?
`NA`
- [x] Any backward compatibility impacted?
`NA`
- [x] Document update required?
`NA`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
`NA`
- How it is tested? Please attach test report.
`NA`
- Is it a performance related change? Please attach the performance test report.
`NA`
- Any additional information to help reviewers in testing this change.
`NA`

- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
`NA`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xuchuanyin/carbondata 0504_assembly

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2270

----
commit de2fc543a2c2af611c3a44ea68e3b882175280d8
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-05-04T13:11:17Z

Remove hadoop/spark/zookeeper related classes from assembly

----

---

qiuchenjian-2

[GitHub] carbondata pull request #2270: [CARBONDATA-2438][Assembly] Remove hadoop/spa...

Github user xuchuanyin commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2270#discussion_r186094736

--- Diff: assembly/pom.xml ---
@@ -89,7 +89,18 @@
<artifactSet>
<includes>
<include>*:*</include>
+ 
+ 
--- End diff --

FYI: If we use this line of code, the assembly jar will only contain carbondata related classes and the final size of assembly-jar will be about 7MB.

But there will be some problems: If carbon use an artifact that is not provided by spark, it will cause runtime error. So we'd better to keep the classes and only remove those are known to be provided by spark.

---

qiuchenjian-2